From owner-freebsd-perl@FreeBSD.ORG Mon Feb 25 02:59:59 2008 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB50C16A403 for ; Mon, 25 Feb 2008 02:59:59 +0000 (UTC) (envelope-from lbr@nerdheaven.dk) Received: from tux.nerdheaven.dk (tux.nerdheaven.dk [193.88.12.43]) by mx1.freebsd.org (Postfix) with ESMTP id A338C13C46B for ; Mon, 25 Feb 2008 02:59:59 +0000 (UTC) (envelope-from lbr@nerdheaven.dk) Received: from localhost (localhost [127.0.0.1]) by tux.nerdheaven.dk (Postfix) with ESMTP id 364483FF4D; Mon, 25 Feb 2008 03:59:57 +0100 (CET) Received: from tux.nerdheaven.dk ([127.0.0.1]) by localhost (tux.nerdheaven.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 39667-05; Mon, 25 Feb 2008 03:59:56 +0100 (CET) Received: by tux.nerdheaven.dk (Postfix, from userid 1021) id 92E753FF4F; Mon, 25 Feb 2008 03:59:56 +0100 (CET) Date: Mon, 25 Feb 2008 03:59:56 +0100 From: Lars Balker Rasmussen To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20080225025956.GC13264@tux.nerdheaven.dk> References: <86zltpzrxt.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86zltpzrxt.fsf@ds4.des.no> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: by amavisd-new at nerdheaven.dk Cc: ports@freebsd.org, perl@freebsd.org Subject: Re: Port dependencies on p5-Test-* X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2008 02:59:59 -0000 On Mon, Feb 25, 2008 at 03:32:46AM +0100, Dag-Erling Smørgrav wrote: > There is a ridiculous amount of p5-* ports that have completely > unnecessary build dependencies on p5-Test-*. These package are usually > only needed to run unit tests (cd ${WRKSRC} && make test), which *none* > of those ports do. > > (ridiculous, in this case, means close to 300) > > What's worse, most of these ports have RUN_DEPENDS = ${BUILD_DEPENDS}, > which means even the prebuilt packages have these unnecessary > dependencies! > > All of this could be avoided by adding these few lines to the port's > Makefile, and removing p5-Test-* from BUILD_DEPENDS: > > pre-configure: > @(cd ${WRKSRC} && ${REINPLACE_CMD} -E -e \ > "s/'?Test::[^']+'?[[:space:]]*=>[[:space:]]'?[0-9.]+'?,//" \ > Makefile.PL) > > (some ports also need to edit Build.PL) > > Alternatively, this could be added to bsd.perl.mk, conditional on the > presence of a PERL_UNTESTIFY_FILES variable which would list Makefile.PL > and / or Build.PL for the ports that require it. I completely agree, and have been weeding both practices from my ports when I touch them. Maybe a blanket sweep of all Test:: dependencies is is in order. (Even better, obsolete 5.6 so Test::More is in core-perl, making it all the simpler.) -- Lars Balker Rasmussen Consult::Perl