Date: Wed, 04 Sep 2013 07:36:13 -0500 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Stephen Montgomery-Smith <stephen@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r326241 - head/math/octave-forge-odepkg Message-ID: <5227293D.30108@missouri.edu> In-Reply-To: <20130904033030.GC71557@FreeBSD.org> References: <201309040138.r841cHYC074414@svn.freebsd.org> <20130904033030.GC71557@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/03/2013 10:30 PM, Alexey Dokuchaev wrote: > On Wed, Sep 04, 2013 at 01:38:17AM +0000, Stephen Montgomery-Smith wrote: >> New Revision: 326241 >> URL: http://svnweb.freebsd.org/changeset/ports/326241 >> >> Log: >> - Set make_jobs_unsafe, otherwise patches can get applied out of order. With this particular port, I am not quite sure exactly what goes wrong. But at some point, it applies a whole bunch of patches within its Makefile. And I was getting "patch already applied" errors. Something was being done out of order - maybe it wasn't specifically the application of the patches. > > Do you see any better solution to this? Maybe force the order somehow? > MAKE_JOBS_UNSAFE should be used as a last resort, when problem cannot be > easily fixed. > > ./danfe (dreaming of 100% jobs-safe ports tree :) I probably could try to find a fix (but I'll have to read up on how gmake performs its -j operations first). However, from a philosophical point of view, if a project external to FreeBSD makes source code that is not safe for the -j option to be used, should FreeBSD ports committers feel that it is our job to correct their source code? I think the answer should be "no," and it seems you disagree. I would like to hear what other people think.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5227293D.30108>