From owner-freebsd-arm@freebsd.org Wed Jul 15 12:43:33 2015 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE1FC9A2BB9 for ; Wed, 15 Jul 2015 12:43:33 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) by mx1.freebsd.org (Postfix) with ESMTP id B38B01059 for ; Wed, 15 Jul 2015 12:43:33 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346) id A4FD3E191; Wed, 15 Jul 2015 12:43:33 +0000 (UTC) Date: Wed, 15 Jul 2015 12:43:33 +0000 To: freebsd-arm@freebsd.org From: "kib (Konstantin Belousov)" Reply-to: D3094+327+b6ce39a707c1ba10@FreeBSD.org Subject: [Differential] [Changed Subscribers] D3094: Fix ARMv8 KSTACK_PAGES issue Message-ID: <3ca8eac321ef9d2db42497eedc233982@localhost.localdomain> X-Priority: 3 Thread-Topic: D3094: Fix ARMv8 KSTACK_PAGES issue X-Herald-Rules: <28>, <31>, <32>, <34> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTE0MDI0ZWQ5YjVlYzUxYzUyMWU4OWFkZjdhIFWmVXU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 12:43:33 -0000 kib added a subscriber: kib. INLINE COMMENTS sys/arm64/include/param.h:98 IMO moving KSTACK_PAGES to GENERIC is not right, since you require now that any kernel config has the statement for KSTACK_PAGES. The knob is not considered something that average user should tune. The more proper solution is to use kstack_pages variable instead of the preprocessing symbol. This might even allow to set the default kernel stack size using tunable. The tricky place is the td0 stack allocation in locore. E.g., on i386 it looks easy to use kstack_pages for the stack size, but it is not possible to fetch the value from the kernel environment so early. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D3094 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: wma_semihalf.com, emaste, zbb, andrew Cc: kib, imp, andrew, freebsd-arm-list, emaste