Date: Fri, 2 Mar 2018 18:23:16 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Yuri Victorovich <yuri@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python <python@FreeBSD.org> Cc: "Tobias C. Berner" <tcberner@FreeBSD.org> Subject: Re: svn commit: r463374 - head/security/nyx Message-ID: <6f698e1f-a5d5-2cd7-b2b7-c288a3c65bb6@FreeBSD.org> In-Reply-To: <201803020651.w226ptn3091275@repo.freebsd.org> References: <201803020651.w226ptn3091275@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/2/18 5:51 PM, Yuri Victorovich wrote: > Author: yuri > Date: Fri Mar 2 06:51:55 2018 > New Revision: 463374 > URL: https://svnweb.freebsd.org/changeset/ports/463374 > > Log: > security/nyx: Add USE_PYTHON=noflavors; Add LICENSE_FILE > > nyx is an app, therefore noflavors. This reason doesn't sound correct. Could you explain this further? Context: FLAVORS are for package building infrastructure to produce multiple variations of the same underlying port, within the same repository/run, in Pythons case, for multiple python versions (pyXY-foo). Whether something is an 'app' or not (by some definition, though i'm assuming it means 'end user program not library'), does not factor into whether or not it has or needs flavors, just whether it supports multiple versions. Note: Whether or not a port has flavor's is orthogonal (in pythons case) to whether or not said packages are, or desired to be by the user, concurrently installable or not. > > Approved by: tcberner (mentor, implicit) > Approved by: portmgr (port compliance, infrastructure) > > Modified: > head/security/nyx/Makefile > > Modified: head/security/nyx/Makefile > ============================================================================== > --- head/security/nyx/Makefile Fri Mar 2 06:31:47 2018 (r463373) > +++ head/security/nyx/Makefile Fri Mar 2 06:51:55 2018 (r463374) > @@ -12,12 +12,13 @@ MAINTAINER= cs@FreeBSD.org > COMMENT= Command-line monitor for Tor > > LICENSE= GPLv3 > +LICENSE_FILE= ${WRKSRC}/LICENSE > > -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}stem>=1.6.0:security/py-stem@${FLAVOR} \ > - ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${FLAVOR} > +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}stem>=1.6.0:security/py-stem@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR} > > USES= python > -USE_PYTHON= distutils autoplist > +USE_PYTHON= distutils autoplist noflavors > NO_ARCH= yes > > PLIST_FILES= man/man1/nyx.1.gz >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6f698e1f-a5d5-2cd7-b2b7-c288a3c65bb6>