Date: Mon, 27 Apr 2015 17:46:48 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199737] [patch] comms/linrad : fix two bugs (fatal on gcc5) Message-ID: <bug-199737-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199737 Bug ID: 199737 Summary: [patch] comms/linrad : fix two bugs (fatal on gcc5) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: hamradio@FreeBSD.org Reporter: marino@FreeBSD.org Assignee: hamradio@FreeBSD.org Keywords: patch Flags: maintainer-feedback?(hamradio@FreeBSD.org) Created attachment 156048 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=156048&action=edit Fix linrad on latest gcc I checked linrad upstream, and they still haven't fixed these two bugs. I am surprised they haven't been reported yet. Without these fixes, linrad cannot be built with gcc5. the menu.c patch simply reverses the order of the condition. One must check the bounds constraint first! It's a pretty dumb mistake but I've seen this kind before. The second one fails because -Werror is set. This took me a while because I couldn't figure out the relationship between ADCHANS and rxchan. In any case, setting 4 locations per channel did indeed allow the array to be big enough. (at first I thought the loop was running too high, but I finally determined the array was too small). These were found on DragonFly that uses gcc5. This patch has not been tested on FreeBSD but I can't how it could possibly fail. It would be good if the ham@ maintainer reports the issue upstream. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199737-13>