From owner-freebsd-rc@FreeBSD.ORG Wed Oct 14 09:45:41 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A53E106566B; Wed, 14 Oct 2009 09:45:41 +0000 (UTC) (envelope-from dimitry@andric.com) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 231C08FC12; Wed, 14 Oct 2009 09:45:41 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:c0:e792:953e:5a9] (unknown [IPv6:2001:7b8:3a7:0:c0:e792:953e:5a9]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E11F05C59; Wed, 14 Oct 2009 11:45:39 +0200 (CEST) Message-ID: <4AD59DCC.9000008@andric.com> Date: Wed, 14 Oct 2009 11:45:48 +0200 From: Dimitry Andric User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.1.4pre) Gecko/20091003 Shredder/3.0pre MIME-Version: 1.0 To: Doug Barton References: <4AD2460A.3000902@FreeBSD.org> In-Reply-To: <4AD2460A.3000902@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: A more thorough "Starting foo:" solution X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 09:45:41 -0000 On 2009-10-11 22:54, Doug Barton wrote: > After giving this a more thorough look I realized that there were > quite a few places where $rc_quiet was being used directly in an rc.d > script (16 scripts total). > > I've already committed this to HEAD in order to try and make the MFC > deadline to potentially get it into 8.0, but I do want to give y'all a > chance to review this change as well. > > If anyone objects to this change being MFC'ed to 8.0-RELEASE, or has > other comments or suggestions please speak up ASAP. I see no problems with MFC'ing, this is a nice way of cleaning up. That said, there are still quite a number of scripts in rc.d that don't check rc_quiet at all, and just echo whatever they like. Therefore, couldn't all those "check_startmsgs && echo foo" constructs, plus the other echo's be replaced with, say, a spam() function from /etc/rc.subr? This function can then check in one central location for rc_startmsgs and decide whether to spam the console or not. One could even start implementing some verbosity level using this... :)