Date: Sat, 22 Dec 2018 10:13:41 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: Kyle Evans <kevans@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: Re: is adding new private symbols to libc frowned upon? Message-ID: <352cae97-2e25-3302-0e4e-e75d4b4b3225@yuripv.net> In-Reply-To: <CACNAnaFTGhWtS-LHa7_hpp1Q-9LYBZ2UbXN-1RcrboL1aGub6A@mail.gmail.com> References: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net> <20181222064138.GM60291@kib.kiev.ua> <CACNAnaFTGhWtS-LHa7_hpp1Q-9LYBZ2UbXN-1RcrboL1aGub6A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN Content-Type: multipart/mixed; boundary="LYW4qOyL853LutqVKVOrNn92HCEK76Sb6"; protected-headers="v1" From: Yuri Pankov <yuripv@yuripv.net> To: Kyle Evans <kevans@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Cc: freebsd-hackers <freebsd-hackers@freebsd.org> Message-ID: <352cae97-2e25-3302-0e4e-e75d4b4b3225@yuripv.net> Subject: Re: is adding new private symbols to libc frowned upon? References: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net> <20181222064138.GM60291@kib.kiev.ua> <CACNAnaFTGhWtS-LHa7_hpp1Q-9LYBZ2UbXN-1RcrboL1aGub6A@mail.gmail.com> In-Reply-To: <CACNAnaFTGhWtS-LHa7_hpp1Q-9LYBZ2UbXN-1RcrboL1aGub6A@mail.gmail.com> --LYW4qOyL853LutqVKVOrNn92HCEK76Sb6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Kyle Evans wrote: > On Sat, Dec 22, 2018 at 12:42 AM Konstantin Belousov > <kostikbel@gmail.com> wrote: >> >> On Sat, Dec 22, 2018 at 04:38:52AM +0300, Yuri Pankov wrote: >>> Essentially, I need the __collate_equiv_value symbol to be visible to= >>> libregex for the changes in https://reviews.freebsd.org/D18531. Is t= he >>> following change OK (it works, at least), or should try to avoid that= ? >>> >>> --- a/lib/libc/locale/Symbol.map >>> +++ b/lib/libc/locale/Symbol.map >>> @@ -212,6 +212,7 @@ FBSD_1.3 { >>> FBSDprivate_1.0 { >>> _PathLocale; >>> __detect_path_locale; >>> + __collate_equiv_value; >>> __collate_load_error; >>> __collate_range_cmp; >>> }; >>> >> Then libregex must always match the installed libc. >> >> I looked at the the libregex/Makefile and my question is, what is the >> difference between exports from libc/regex vs. libregex. Can libregex= >> become ELF filter for libc ? >> >=20 > libregex is going to be getting more complicated [1] after a couple > more exp-runs. I can possibly re-work it to make a filter work > (perhaps?), but I'm not sure how badly that will impact the > performance of libc regex. >=20 > [1] https://reviews.freebsd.org/D12935 I don't think making libregex a filter for libc will work here as you intend it to have different functionality, even if compiling the same source files. OTOH, the function isn't easily decoupled from libc (if at all) as it needs to know internal implementation details, hence my original question= =2E --LYW4qOyL853LutqVKVOrNn92HCEK76Sb6-- --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwd5CUACgkQk4vgf7Eq 4Wz7Rwf+PVHFP/S1MqTzY6tzexeIcOWwpz+nXDVYVbJ8OIUwjxy1Inv+o0Re6k0Y LRa7uSfbb0vLbLExcYodmQ7zFJ+LLqJU10xZHpkmLRSxKFecZUvg8hijyuNX6KLh F8D5jbT9BATmms9EwJnc/6BqVdY2DC+Dpx2BvXA2DDjoSfT0HuPR+bJILwyGp+Kd zx/ZIXdyeKjzav3WNuU7SzNsm40HXdz4GySAUiTxWCjb8SwmwEL5rRQZ0Ln5xB9n blhHEcmWOd6fBqCrHTqbCP80N3q4226PtoC6a2zpa9XrWUDqf5V6x1EQzUKPSBUD t4w29DhGYwZMgXSER3BP+xNsnhEitQ== =hOLE -----END PGP SIGNATURE----- --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?352cae97-2e25-3302-0e4e-e75d4b4b3225>