From owner-freebsd-net@freebsd.org Wed Sep 18 07:19:21 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EC7CEF469F for ; Wed, 18 Sep 2019 07:19:21 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YBDn0yw1z3xD2 for ; Wed, 18 Sep 2019 07:19:20 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from [IPv6:2a02:8109:1140:c3d:14c8:fd55:266f:848c] (unknown [IPv6:2a02:8109:1140:c3d:14c8:fd55:266f:848c]) (Authenticated sender: lurchi) by drew.franken.de (Postfix) with ESMTPSA id A1913721E281E; Wed, 18 Sep 2019 09:10:31 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: BBR patches? From: Michael Tuexen In-Reply-To: Date: Wed, 18 Sep 2019 09:10:30 +0200 Cc: Randall Stewart , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLACK autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 46YBDn0yw1z3xD2 X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of michael.tuexen@lurchi.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=michael.tuexen@lurchi.franken.de X-Spamd-Result: default: False [10.01 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[27.24.175.193.list.dnswl.org : 127.0.5.1]; IP_SCORE(-1.79)[ip: (-9.09), ipnet: 193.174.0.0/15(0.10), asn: 680(0.07), country: DE(-0.01)]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; SUBJECT_ENDS_QUESTION(1.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[franken.de]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; GREYLIST(0.00)[pass,body]; RCVD_TLS_ALL(0.00)[] X-Spam: Yes X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 07:19:22 -0000 > On 18. Sep 2019, at 08:19, vm finance wrote: >=20 > correcting a typo: >=20 > svn co svn://svn.freebsd.org/base/head /usr/src > current revision: 352434 I suggest to build/install head first without any patches. After that = has worked, apply the patches you are interested in. That way it is easy to separate = generic build issues and issue specific to a patch. Best regards Michael >=20 > Thank you! >=20 > On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: >=20 >> Actually I am on head already as mentioned previously. Pulled it = using >> yesterday: >>=20 >> svn co svn://svn.freebsd.org/base/head /use/src >>=20 >>=20 >> If you could pls let me know the new patch, I can try that. >>=20 >> Thanks >>=20 >> Sent from my iPhone >>=20 >> On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: >>=20 >> There have been several patches pre-this one that provide >> the infrastructure to support BBR. >>=20 >> Release 12.0 will *not* have these patches and will *not* compile it. >>=20 >> I have no intention at this point in doing a MFC of this work.. so if = you >> want >> to run BBR you need to run Head >>=20 >> R >>=20 >> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: >>=20 >>=20 >> Hi Randall, >>=20 >>=20 >> Could you please provide a pointer to the latest patch. I had applied = the >> one you published Sep-10. >>=20 >>=20 >> Following is what I have done: >>=20 >> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>=20 >> 2. Got VM up under VMPlayer on x86 laptop >>=20 >> 3. Checked out latest codebase from freebsd repo: >>=20 >> svn co svn://svn.freebsd.org/base/head /usr/src* >>=20 >> cd /usr/src; >>=20 >> make buildworld buildkernel >>=20 >> [this is where make fails when patch is applied] >>=20 >>=20 >> I could try to build with your latest patch - please send me a = pointer. >>=20 >>=20 >> Thanks for your help! >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: >>=20 >> Looking at your make file log I can=E2=80=99t really tell what you = are doing. >>=20 >>=20 >> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>=20 >>=20 >> Are you cross compiling? >>=20 >>=20 >> I have done the old fashioned kernel make >>=20 >>=20 >> i.e. >>=20 >>=20 >> cd src/sys/amd64/config >>=20 >> config headvm >>=20 >> cd ../compile/headvm >>=20 >>=20 >> make cleandepend ; make depend; make -j3 >>=20 >>=20 >> I have done >>=20 >>=20 >> cd src >>=20 >> make buildkernel KERNCONF=3Dheadvm >>=20 >>=20 >> And even >>=20 >>=20 >> make buildkernel KERNCONF=3DGENERIC >>=20 >>=20 >> to make sure that the build works without bbr. >>=20 >>=20 >> I attach my headvm config.. >>=20 >>=20 >> What exactly are you building and how? kernel config too please? >>=20 >>=20 >> R >>=20 >>=20 >>=20 >>=20 >>=20 >> On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >>=20 >>=20 >> looking >>=20 >>=20 >> I was at 352408.. let me update and try it >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >>=20 >>=20 >> Hmm >>=20 >>=20 >> Did you get the patch I updated too this am? >>=20 >>=20 >> I have built it both with and without the bbr stack and had no = issue.. >> there was >>=20 >> an issue with KTLS before the update though. >>=20 >>=20 >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>=20 >>=20 >> Got it - thank you! >>=20 >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN >> info + make error mesg. >>=20 >>=20 >> Please let me know what am I missing here? >>=20 >>=20 >> Thanks! >>=20 >>=20 >> #svnlite revision >>=20 >> Path: . >>=20 >> Working Copy Root Path: /usr/src >>=20 >> URL: svn://svn.freebsd.org/base/head >>=20 >> Relative URL: ^/head >>=20 >> Repository Root: svn://svn.freebsd.org/base >>=20 >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>=20 >> Revision: 352436 >>=20 >> Node Kind: directory >>=20 >> Schedule: normal >>=20 >> Last Changed Author: jah >>=20 >> Last Changed Rev: 352434 >>=20 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >>=20 >> root@osboxes:/usr/src # >>=20 >>=20 >> -------------------------------------------- snip >> ---------------------------- >>=20 >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >> bcache.llo interp_simple.llo zfs_cmd.llo >>=20 >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>=20 >> =3D=3D=3D> sys (cleandir) >>=20 >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> opt_kern_tls.h >>=20 >> rm: x86: is a directory >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[3]: stopped in /usr/src/sys >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[2]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[1]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make: stopped in /usr/src >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >>=20 >> Got it - thank you! >>=20 >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN >> info + make error mesg. >>=20 >> I have also attached the entire build log...snippet is below >>=20 >>=20 >> Please let me know what am I missing here? >>=20 >>=20 >> Thanks! >>=20 >>=20 >> #svnlite revision >>=20 >> Path: . >>=20 >> Working Copy Root Path: /usr/src >>=20 >> URL: svn://svn.freebsd.org/base/head >>=20 >> Relative URL: ^/head >>=20 >> Repository Root: svn://svn.freebsd.org/base >>=20 >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>=20 >> Revision: 352436 >>=20 >> Node Kind: directory >>=20 >> Schedule: normal >>=20 >> Last Changed Author: jah >>=20 >> Last Changed Rev: 352434 >>=20 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >>=20 >> root@osboxes:/usr/src # >>=20 >>=20 >> -------------------------------------------- snip >> ---------------------------- >>=20 >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >> bcache.llo interp_simple.llo zfs_cmd.llo >>=20 >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>=20 >> =3D=3D=3D> sys (cleandir) >>=20 >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> opt_kern_tls.h >>=20 >> rm: x86: is a directory >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[3]: stopped in /usr/src/sys >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[2]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[1]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make: stopped in /usr/src >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >>=20 >> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >>=20 >> to have fq.. they built an alternate means of doing pacing into bbr. >>=20 >>=20 >> In either case our testing has shown that our pacing is more accurate = than >>=20 >> either fq or the internal pacer :) >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>=20 >>=20 >> Thanks Randall. >>=20 >> I was able to apply the patch - now rebuilding the kernel. Would = update on >> how it goes. >>=20 >>=20 >> BTW, is there any description on how lack of tc_fq under FreeBSD is >> compensated here? >>=20 >> The original BBR patches on Linux show that as a must-have? Is that >> functionality implemented via tcp_ratelimit.[ch]? >>=20 >>=20 >> Any pointers to existing presentations/discussions highly = appreciated? >>=20 >>=20 >> Thanks a lot. >>=20 >>=20 >> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>=20 >> You should be able to compile it against the current head. I re-doing = that >> now (had an >>=20 >> issue with my machine and had to roll it back to a backup). >>=20 >>=20 >> When I put the patch up on Sept 10th it complied with and without BBR = on >> whatever >>=20 >> was that rev.. >>=20 >>=20 >> Looking in the commit logs that would have been around 352191 >>=20 >>=20 >> Hope that helps >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>=20 >>=20 >> Hi Randall, >>=20 >>=20 >> Thanks for releasing BBR patch: >>=20 >> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>=20 >>=20 >> Could you please let me know what SVN/GIT label tag this is based on? = I >> would like to patch and experiment with it. I couldn't find this info = in >> the released patch. >>=20 >>=20 >> Thanks a lot! >>=20 >>=20 >> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>=20 >> rrs@ has just posted the BBR patch to phabricator: >>=20 >>=20 >> https://reviews.freebsd.org/D21582 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"