Date: Wed, 18 Apr 2018 13:49:52 -0400 From: "Jason E. Hale" <jhale@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Adriaan de Groot <adridg@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files Message-ID: <CAJE75NG0kA5a6zjfnx3bZcxRuLzHSSw8GuWUntV18UV1KFGUDw@mail.gmail.com> In-Reply-To: <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net> References: <201804172327.w3HNRLIF044763@repo.freebsd.org> <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> <3174473.pFhRGbBKQR@beastie.bionicmutton.org> <20180418111002.b7ocgnvfo25s5ofk@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 18, 2018 at 7:10 AM, Mathieu Arnold <mat@freebsd.org> wrote: > On Wed, Apr 18, 2018 at 10:21:16AM +0200, Adriaan de Groot wrote: >> On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote: >> > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote: >> > > Log: >> > > - Update audio/liblastfm to 1.0.9-5-g4433165 [1] >> > > - Add audio/liblastfm-qt5 slave port which provides a Qt 5 interface [1] >> > >> > Why not add flavors instead of a slave port? >> >> >> In an existing review https://reviews.freebsd.org/D14660 you (Mat) say of a >> different port >> >> """We currently do not accept flavors that add new packages though, so this >> change will be able to go in when ports-mgmt/poudriere is updated to 3.3.""" >> >> That would preclude flavorizing liblastfm, wouldn't it? There are a lot of Qt4/ >> Qt5 ports that could be flavorized and/or swept together like that. > > Mmmm, that sentence is not true any more, 3.3 was supposed to be the > first release to have the 32k packages limit fix, but as it was taking a > bit more time to get there, to the fix was backported to the 3.2 branch > and is in 3.2.6. So, flavorizing is possible now. (Still requires > portmgr approval.) > > I did submit a review for this (https://reviews.freebsd.org/D14667) a month ago and you rejected it, so I decided to move forward. Poudriere still has a bug in it where it is flavorizing the WRKDIR of the math/fftw3 dependency, however, which causes the build to fail without that ugly hack I put in. The port builds fine outside of poudriere without the hack. I did set up the port to be easily converted to FLAVORS, but maybe that bug should be fixed first before I re-attempt? - Jason
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NG0kA5a6zjfnx3bZcxRuLzHSSw8GuWUntV18UV1KFGUDw>