Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 4 Mar 2008 10:52:37 +0100
From:      "Raphael H. Becker" <rabe@p-i-n.com>
To:        Pav Lucistnik <pav@freebsd.org>
Cc:        cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/net/rsync Makefile distinfo ports/net/rsync/files extra-patches-acls.diff patch-CVE-2007-4091 patch-CVE-2007-6199
Message-ID:  <20080304095237.GA5944@p-i-n.com>
In-Reply-To: <200803032239.m23MdIis005923@repoman.freebsd.org>
References:  <200803032239.m23MdIis005923@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi Pav,

On Mon, Mar 03, 2008 at 10:39:18PM +0000, Pav Lucistnik wrote:
> pav         2008-03-03 22:39:18 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net/rsync            Makefile distinfo 
>   Removed files:
>     net/rsync/files      extra-patches-acls.diff 
>                          patch-CVE-2007-4091 patch-CVE-2007-6199 
>   Log:
>   - Update to 3.0.0
>   
>   Revision  Changes    Path
>   1.125     +1 -43     ports/net/rsync/Makefile
>   1.49      +3 -3      ports/net/rsync/distinfo
>   1.2       +0 -26     ports/net/rsync/files/extra-patches-acls.diff (dead)
>   1.2       +0 -60     ports/net/rsync/files/patch-CVE-2007-4091 (dead)
>   1.2       +0 -340    ports/net/rsync/files/patch-CVE-2007-6199 (dead)

Is there a reason for disabling the --flags from rsync? flags are
somewhat useful for rsyncing jails. patches/ was stripped from the
distfile and is released in a separate rsync-patches-<ver>.tar.gz

I used a corrected flags.diff[1] for 2.6.9 from the maintainer, which 
was able to rsync even hardlinks on immutable files[2][3].

The 3.0 version of this can handle this gracefully, see rsync-3.0.0/patches/fileflags.diff 
in http://www.samba.org/ftp/rsync/rsync-patches-3.0.0.tar.gz 

Please include the new rsync-patches to net/rsync and make them optionally
available via the OPTIONS, hopefully the new patches will handle
hardlinks on immutable files gracefully.

Regards
Raphael Becker
 
PS: rsync'ing jails with 2.6.9 plus[1]:

ROPTS="-avHWx -e ssh --flags --delete"
SRC="root@jailhost1/data/jails/foo/"
DST="/data/jails/foo/"
/usr/local/bin/rsync ${ROPTS} ${SRC} ${DST}

[1] http://rabe.uugrn.org/files/replacement_for_net_rsync_work_rsync-2.6.9_patches_flags.diff
by Rolf Grossmann in 1/2007 
[2] http://docs.freebsd.org/cgi/getmsg.cgi?fetch=735396+0+archive/2006/freebsd-ports/20061210.freebsd-ports
[3] http://docs.freebsd.org/cgi/getmsg.cgi?fetch=75147+0+archive/2007/freebsd-ports/20070225.freebsd-ports



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080304095237.GA5944>