From owner-cvs-ports@FreeBSD.ORG Tue Mar 4 10:09:40 2008 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27CF11065676; Tue, 4 Mar 2008 10:09:40 +0000 (UTC) (envelope-from rabe@p-i-n.com) Received: from mx1.p-i-n.com (mx1.p-i-n.com [62.156.172.131]) by mx1.freebsd.org (Postfix) with ESMTP id C04668FC28; Tue, 4 Mar 2008 10:09:39 +0000 (UTC) (envelope-from rabe@p-i-n.com) Received: from p-i-n.com (pinserv2.p-i-n.com [10.101.240.52]) by mx1.p-i-n.com (8.13.8/8.13.8) with ESMTP id m249qhn4024533; Tue, 4 Mar 2008 10:52:43 +0100 (CET) (envelope-from rabe@p-i-n.com) Received: from pinserv2.p-i-n.com (localhost.p-i-n.com [127.0.0.1]) by p-i-n.com (8.13.6/8.13.6) with ESMTP id m249qbZ8052800; Tue, 4 Mar 2008 10:52:37 +0100 (CET) (envelope-from rabe@pinserv2.p-i-n.com) Received: (from rabe@localhost) by pinserv2.p-i-n.com (8.13.6/8.13.6/Submit) id m249qbYW052799; Tue, 4 Mar 2008 10:52:37 +0100 (CET) (envelope-from rabe) Date: Tue, 4 Mar 2008 10:52:37 +0100 From: "Raphael H. Becker" To: Pav Lucistnik Message-ID: <20080304095237.GA5944@p-i-n.com> References: <200803032239.m23MdIis005923@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200803032239.m23MdIis005923@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i Organization: PHOENIX Pharmahandel AG & Co KG, Mannheim, Deutschland Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/rsync Makefile distinfo ports/net/rsync/files extra-patches-acls.diff patch-CVE-2007-4091 patch-CVE-2007-6199 X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 10:09:40 -0000 Hi Pav, On Mon, Mar 03, 2008 at 10:39:18PM +0000, Pav Lucistnik wrote: > pav 2008-03-03 22:39:18 UTC > > FreeBSD ports repository > > Modified files: > net/rsync Makefile distinfo > Removed files: > net/rsync/files extra-patches-acls.diff > patch-CVE-2007-4091 patch-CVE-2007-6199 > Log: > - Update to 3.0.0 > > Revision Changes Path > 1.125 +1 -43 ports/net/rsync/Makefile > 1.49 +3 -3 ports/net/rsync/distinfo > 1.2 +0 -26 ports/net/rsync/files/extra-patches-acls.diff (dead) > 1.2 +0 -60 ports/net/rsync/files/patch-CVE-2007-4091 (dead) > 1.2 +0 -340 ports/net/rsync/files/patch-CVE-2007-6199 (dead) Is there a reason for disabling the --flags from rsync? flags are somewhat useful for rsyncing jails. patches/ was stripped from the distfile and is released in a separate rsync-patches-.tar.gz I used a corrected flags.diff[1] for 2.6.9 from the maintainer, which was able to rsync even hardlinks on immutable files[2][3]. The 3.0 version of this can handle this gracefully, see rsync-3.0.0/patches/fileflags.diff in http://www.samba.org/ftp/rsync/rsync-patches-3.0.0.tar.gz Please include the new rsync-patches to net/rsync and make them optionally available via the OPTIONS, hopefully the new patches will handle hardlinks on immutable files gracefully. Regards Raphael Becker PS: rsync'ing jails with 2.6.9 plus[1]: ROPTS="-avHWx -e ssh --flags --delete" SRC="root@jailhost1/data/jails/foo/" DST="/data/jails/foo/" /usr/local/bin/rsync ${ROPTS} ${SRC} ${DST} [1] http://rabe.uugrn.org/files/replacement_for_net_rsync_work_rsync-2.6.9_patches_flags.diff by Rolf Grossmann in 1/2007 [2] http://docs.freebsd.org/cgi/getmsg.cgi?fetch=735396+0+archive/2006/freebsd-ports/20061210.freebsd-ports [3] http://docs.freebsd.org/cgi/getmsg.cgi?fetch=75147+0+archive/2007/freebsd-ports/20070225.freebsd-ports