From owner-cvs-all Tue Aug 15 2:45: 1 2000 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.freebsd.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id F269837B9B7; Tue, 15 Aug 2000 02:44:53 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (hak.nat.Awfulhak.org [172.31.0.12]) by storm.FreeBSD.org.uk (8.9.3/8.9.3) with ESMTP id KAA66832; Tue, 15 Aug 2000 10:44:50 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id KAA01236; Tue, 15 Aug 2000 10:17:37 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200008150917.KAA01236@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Archie Cobbs Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: cvs commit: src/sys/netgraph ng_pppoe.c In-Reply-To: Message from Archie Cobbs of "Mon, 14 Aug 2000 18:25:04 PDT." <200008150125.SAA40367@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 15 Aug 2000 10:17:36 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > archie 2000/08/14 18:25:04 PDT > > Modified files: (Branch: RELENG_4) > sys/netgraph ng_pppoe.c > Log: > MFC: (rev. 1.26) strip address and control field bytes from outgoing frames > MFC: (rev. 1.24) misc fixes (not described in that commit message) > > Revision Changes Path > 1.23.2.1 +29 -5 src/sys/netgraph/ng_pppoe.c I didn't see the original commit (sorry, I would have followed-up to that). Is this actually necessary ? Surely the ppp implementation shouldn't be prepending this stuff ? I would think that if this functionality is required it should be enabled/disabled via a control message and should work on inbound data too. -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message