Date: Mon, 20 Jun 2016 16:59:27 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Alan Somers" <asomers@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300881 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs geom Message-ID: <FDB9C7A6-02C7-4469-941E-8E56ABDEBA1B@FreeBSD.org> In-Reply-To: <201605272232.u4RMWjku087648@repo.freebsd.org> References: <201605272232.u4RMWjku087648@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, It looks like this change breaks boot on my machine. I’m running a root-on-ZFS system and reliably see this panic during boot. It’s a 4 disk raidz-1. It’s now running r302028 with r300881 backed out, and booting fine. The panic: panic: solaris assert: refcount(count(&spa->spa_refcount) >= spa->spa_minref || MUTEX_HELD(&spa_namespace_lock), file: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c, line: 863 Unfortunately I can’t get a dump, but here’s a picture of the backtrace: https://people.freebsd.org/~kp/zfs_panic.jpg Regards, Kristof On 28 May 2016, at 0:32, Alan Somers wrote: > Author: asomers > Date: Fri May 27 22:32:44 2016 > New Revision: 300881 > URL: https://svnweb.freebsd.org/changeset/base/300881 > > Log: > Avoid issuing spa config updates for physical path when not > necessary > > ZFS's configuration needs to be updated whenever the physical path > for a > device changes, but not when a new device is introduced. This is > because new > devices necessarily cause config updates, but only if they are > actually > accepted into the pool. > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > Split vdev_geom_set_physpath out of vdev_geom_attrchanged. When > setting the vdev's physical path, only request a config update if > the physical path has changed. Don't request it when opening a > device for the first time, because the config sync will happen > anyway upstack. > > sys/geom/geom_dev.c > Split g_dev_set_physpath and g_dev_set_media out of > g_dev_attrchanged > > Submitted by: will, asomers > MFC after: 4 weeks > Sponsored by: Spectra Logic Corp > Differential Revision: https://reviews.freebsd.org/D6428 > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > head/sys/geom/geom_dev.c From owner-svn-src-all@freebsd.org Mon Jun 20 15:27:19 2016 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A039DAC48D7; Mon, 20 Jun 2016 15:27:19 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22d.google.com (mail-ob0-x22d.google.com [IPv6:2607:f8b0:4003:c01::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64846198C; Mon, 20 Jun 2016 15:27:19 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ob0-x22d.google.com with SMTP id ot10so515685obb.2; Mon, 20 Jun 2016 08:27:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=Ee7A08SnpK/qwPMZTJ0PX7Uk9Wrsmf4tozGE+Wa1crs=; b=Rp2YjmIceElMXfXyp3l7zbd+FG2D9n4b8D2x1KIHiD9DQQDvyAfOQFI4rFuTHcAmzl CH+Q3cbtOjktZqGWSdHWxkN2rGn9aLhvi9LGKDk3o9XNLGIJ9PNtQ6mTvQgboNSJH4Ep YGh7vyIx5yl+SQsMhjrEo32bFvMaZE+txT+H2vOJxcDVQqZNC+4vuKVRqx0J2mEhC4pB zW32oSb6zSWt0kk/ZhC0LEITvpgrxSfTnM4M7YMNynou8t3ExOi7hXgNisNO1ld0/5Kx exmzeyk2+Tsf0DNP/+HRj3mfWEh+vOdUpI3D2gD5r+ZW/4bVj0JdbJKcBjH8cylgUlOX eAzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=Ee7A08SnpK/qwPMZTJ0PX7Uk9Wrsmf4tozGE+Wa1crs=; b=M0buPYKdAJfRTeoB0WtXYXU5uFjN5vIeLOTpe9pWWYRGxlgcdDI8Hp9+0jJtIAQyjb ucDsnNXiZYiixWRo061pAmkAwhtiyu2z2JPmRogHlvj/xIgd5isa7uB74X3CCN1MX1Ii EGHWlQy6zzdVFmB6QtZI1kP6nJCrPmqLc7t0Sn008G8Wh+LItiSLItDKgwEsba+CaOlG wjBmJO3siTbKuwn8NKY3ebZQFrXNuwCreHv9vSWYBn3MBxgWYBkY5XSZ4x9hthyjFf5D adoW8HCGT6Mnxor4QmfBqG+MDjlq1TA4E+a+vfLmHUdpyNyokuHoW2xuEbJgtAilR0Rg isQA== X-Gm-Message-State: ALyK8tI9OJu99UaLTau5H8l7He2S8r/Z6R6kg1USfDqhfgy0t4cCKJOFczeMy5UN/R4gi2O8BmfmDI4LLC9bwA== X-Received: by 10.157.0.74 with SMTP id 68mr11008420ota.55.1466436438449; Mon, 20 Jun 2016 08:27:18 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.202.102.206 with HTTP; Mon, 20 Jun 2016 08:27:17 -0700 (PDT) In-Reply-To: <FDB9C7A6-02C7-4469-941E-8E56ABDEBA1B@FreeBSD.org> References: <201605272232.u4RMWjku087648@repo.freebsd.org> <FDB9C7A6-02C7-4469-941E-8E56ABDEBA1B@FreeBSD.org> From: Alan Somers <asomers@freebsd.org> Date: Mon, 20 Jun 2016 09:27:17 -0600 X-Google-Sender-Auth: gvyGmPphMt_dHbGBCHsGMh5XdFM Message-ID: <CAOtMX2iGZG0ijnTcsM0t7aSKMXTfYs0vH5xcwCpm5bgpWt_11g@mail.gmail.com> Subject: Re: svn commit: r300881 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs geom To: Kristof Provost <kp@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 20 Jun 2016 15:27:19 -0000 You say it's a 4-disk RAIDZ1. Anything topologically weird, like a log, cache or spare device? SAS or SATA? Any SAS expanders? Please open a bug for this and assign to me so we can be sure to get this fixed in time for 11.0. -Alan On Mon, Jun 20, 2016 at 8:59 AM, Kristof Provost <kp@freebsd.org> wrote: > Hi, > > It looks like this change breaks boot on my machine. > I=E2=80=99m running a root-on-ZFS system and reliably see this panic duri= ng boot. > It=E2=80=99s a 4 disk raidz-1. > > It=E2=80=99s now running r302028 with r300881 backed out, and booting fin= e. > > The panic: > panic: solaris assert: refcount(count(&spa->spa_refcount) >=3D spa->spa_m= inref > || > MUTEX_HELD(&spa_namespace_lock), file: > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c, line: > 863 > > Unfortunately I can=E2=80=99t get a dump, but here=E2=80=99s a picture of= the backtrace: > https://people.freebsd.org/~kp/zfs_panic.jpg > > Regards, > Kristof > > On 28 May 2016, at 0:32, Alan Somers wrote: > > Author: asomers > Date: Fri May 27 22:32:44 2016 > New Revision: 300881 > URL: https://svnweb.freebsd.org/changeset/base/300881 > > Log: > Avoid issuing spa config updates for physical path when not necessary > > ZFS's configuration needs to be updated whenever the physical path for a > device changes, but not when a new device is introduced. This is because = new > devices necessarily cause config updates, but only if they are actually > accepted into the pool. > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > Split vdev_geom_set_physpath out of vdev_geom_attrchanged. When > setting the vdev's physical path, only request a config update if > the physical path has changed. Don't request it when opening a > device for the first time, because the config sync will happen > anyway upstack. > > sys/geom/geom_dev.c > Split g_dev_set_physpath and g_dev_set_media out of > g_dev_attrchanged > > Submitted by: will, asomers > MFC after: 4 weeks > Sponsored by: Spectra Logic Corp > Differential Revision: https://reviews.freebsd.org/D6428 > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c > head/sys/geom/geom_dev.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FDB9C7A6-02C7-4469-941E-8E56ABDEBA1B>