Date: Tue, 7 Apr 1998 11:55:12 +0200 From: Eivind Eklund <eivind@yes.no> To: Frank Nobis <fn@Radio-do.de>, Poul-Henning Kamp <phk@FreeBSD.ORG> Cc: current@FreeBSD.ORG Subject: Re: LINT broken in brooktree848.c ? Message-ID: <19980407115512.57503@follo.net> In-Reply-To: <199804061735.TAA13185@trinity.radio-do.de>; from Frank Nobis on Mon, Apr 06, 1998 at 07:35:34PM %2B0200 References: <9394.891847811@critter.freebsd.dk> <199804061735.TAA13185@trinity.radio-do.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 06, 1998 at 07:35:34PM +0200, Frank Nobis wrote: > > > > cc -c -O -pipe -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wuninitialized -nostdinc -I- -I. -I../.. -I/usr/include -DKERNEL -include opt_global.h ../../pci/brooktree848.c > > ../../pci/brooktree848.c:232: opt_bktr.h: No such file or directory > > Oops, my fault. > > The last patch was incomplete. I forget to update options.i386 > since I need to override the tuner detection. > > Here is a patch: This is a style-violation compared to the description at the start of conf/options. First of all, it's option definition should go in conf/options, not i386/conf/options.i386, as the cards are not i386 specific. Secondly, the #define should end up in opt_brooktree848.h (or in opt_override_tuner.h if more files in brooktree848.c is in the loop for using it). Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980407115512.57503>