From owner-cvs-all Fri Dec 24 16:50:21 1999 Delivered-To: cvs-all@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 2195215099; Fri, 24 Dec 1999 16:50:17 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 155641CC6; Sat, 25 Dec 1999 08:50:10 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Marcel Moolenaar Cc: Bruce Evans , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 In-Reply-To: Message from Marcel Moolenaar of "Fri, 24 Dec 1999 09:53:52 +0100." <386334A0.99AF5B87@scc.nl> Date: Sat, 25 Dec 1999 08:50:10 +0800 From: Peter Wemm Message-Id: <19991225005010.155641CC6@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Marcel Moolenaar wrote: > Bruce Evans wrote: > > > > I couldn't disagree more. It is a matter of fact that strfile must be > > bootstrapped, even for certain old versions of FreeBSD that have it in > > /usr/games, because it is invoked by buildworld with a new flag (-C) > > which old versions of strfile don't have. > > Yes, but strfile shouldn't actually be in /usr/games IMO. It should be > in /usr/bin or be a special purpose build tool that never gets > installed. > > Adding the -C option was probably a mistake as well. It's sole purpose > is to support the FreeBSD tag, right? -C is silly. It adds a flag to the header of the generated files to say "this data *might* have a comment". fortune looks to see if there "might" be a comment and skips the double delimiters if so. The double delimiter is otherwise illegal. If an old fortune binary sees a new file, it won't know about the double delimiter. If a new fortune sees the double delimiter it will ignore it. This is exactly the same behavior that would happen if -C was unconditional. -C should be removed and the test for the double delimter should be unconditional. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message