Date: Mon, 10 Feb 2003 02:44:08 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Sean Chittenden <seanc@FreeBSD.ORG>, <audit@FreeBSD.ORG> Subject: Re: WARNS = 2, sbin/ping... Message-ID: <20030210024135.N997-100000@gamplex.bde.org> In-Reply-To: <xzpof5l60od.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 9 Feb 2003, Dag-Erling Smorgrav wrote: > Sean Chittenden <seanc@FreeBSD.org> writes: > > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2. Once > > upon a tie it used to be WARNS5, but the patch has rotted some. The > > biggie in this one was collisions with sin(3) and sockaddr_in variable > > sin. > > That's a compiler bug (unless <math.h> is in scope). The correct > solution is not to rename the variable, but to add -fno-builtin to > CFLAGS globally, and fix those parts of the tree that break due to > missing includes. Who knows, we might even uncover libc bugs that > have been hitherto been masked by the compiler. Script started on Mon Feb 10 02:42:09 2003 ttyp0:bde@besplex:/tmp> grep math.h /usr/src/sbin/ping/ping.c #include <math.h> ttyp0:bde@besplex:/tmp> exit Script done on Mon Feb 10 02:42:22 2003 [wollman added this include long ago to support printing standard deviations.] Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030210024135.N997-100000>