From owner-svn-src-head@FreeBSD.ORG Tue Jan 22 18:34:18 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 03B77E07; Tue, 22 Jan 2013 18:34:18 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) by mx1.freebsd.org (Postfix) with ESMTP id 9CEE9C34; Tue, 22 Jan 2013 18:34:17 +0000 (UTC) Received: by mail-ie0-f181.google.com with SMTP id 16so11958983iea.40 for ; Tue, 22 Jan 2013 10:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=KobalvK5J08E+f0s0qCboRqDOzxdBB548hL6P93D6lc=; b=vMIIZ4B3AjIsnT91JMlA5H6NOC2qM2ZcNzhK426/ncgHliRERjB/VTi8ijQTT4Zu0R u8jnPOlPMO/JZIcSthwRj0osLfDlvUYH6oZFwlFBTkNI2iymITY6AXxf9pDgNeXbEmVk W6ala5TI/ABYOYbqzXj0rqKtIKicovV2Ka1oLM+XDUDvD3fczp/U0pk/enl2yDEq3Dyh +VdIDlJsj71O2JF66xCNFd16GjhcZRlU6k4t+Vfu1vu/HqCF1zM5Kn0p8t3d4j6NUBwM fb9sVZHUCrVMZXBZbSDudETFBxHX7iHm2GUGH1St96ntiGN95JdXNRuvzOJYJKSdlJkl eJrA== X-Received: by 10.50.158.170 with SMTP id wv10mr12852389igb.75.1358879651164; Tue, 22 Jan 2013 10:34:11 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.64.16.73 with HTTP; Tue, 22 Jan 2013 10:33:41 -0800 (PST) In-Reply-To: <20130122181348.GA1662@lor.one-eyed-alien.net> References: <201301212240.r0LMedcF088022@svn.freebsd.org> <20130122181348.GA1662@lor.one-eyed-alien.net> From: Chris Rees Date: Tue, 22 Jan 2013 18:33:41 +0000 X-Google-Sender-Auth: OXAioJFwnOrA9Li1vZlzzO4WG1c Message-ID: Subject: Re: svn commit: r245752 - in head: etc share/mk To: Brooks Davis Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2013 18:34:18 -0000 On 22 January 2013 18:13, Brooks Davis wrote: > On Tue, Jan 22, 2013 at 05:55:31PM +0000, Chris Rees wrote: >> On 21 January 2013 22:40, Brooks Davis wrote: >> > Author: brooks >> > Date: Mon Jan 21 22:40:39 2013 >> > New Revision: 245752 >> > URL: http://svnweb.freebsd.org/changeset/base/245752 >> > >> > Log: >> > Replace all known uses of ln in the build process with appropriate >> > install -l invocations via new INSTALL_LINK and INSTALL_SYMLINK >> > variables. >> > >> > Sponsored by: DARPA, AFRL >> > Reviewed by: ian, ray, rpaulo >> > >> > Modified: >> > head/etc/Makefile >> > head/share/mk/bsd.incs.mk >> > head/share/mk/bsd.info.mk >> > head/share/mk/bsd.lib.mk >> > head/share/mk/bsd.links.mk >> > head/share/mk/bsd.man.mk >> > head/share/mk/bsd.own.mk >> > >> > Modified: head/etc/Makefile >> > ============================================================================== >> > --- head/etc/Makefile Mon Jan 21 22:32:00 2013 (r245751) >> > +++ head/etc/Makefile Mon Jan 21 22:40:39 2013 (r245752) >> > @@ -324,26 +324,29 @@ distrib-dirs: >> > -f $$m -p $$d; \ >> > ${MTREE_CMD} -deU ${MTREE_FOLLOWS_SYMLINKS} -f $$m -p $$d; \ >> > done; true >> > - ln -sfh usr/src/sys ${DESTDIR}/sys >> > + ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys >> >> This broke installworld for me, because of the different behaviour. >> >> ln -sf overwrites existing symlinks, whereas install -l a b puts a >> symlink to a inside itself... which fails on a read-only src (NFS >> mounted). >> >> Perhaps it's install misbehaving? I can't work out if it's >> bootstrapped properly; we should be using new install(1), are we? > > Sorry about that. It's fixed. > I presume r245793, thank you :) Chris