From owner-freebsd-ports@FreeBSD.ORG Thu Jul 12 04:26:37 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35374106564A; Thu, 12 Jul 2012 04:26:37 +0000 (UTC) (envelope-from henry.hu.sh@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9CD358FC16; Thu, 12 Jul 2012 04:26:36 +0000 (UTC) Received: by ggnm2 with SMTP id m2so2292041ggn.13 for ; Wed, 11 Jul 2012 21:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=3ht/VB0/TJlw/AxmaEUB0Dm58rqKLk2YJbT33LtCErM=; b=nLFosnbwVL6RONMGKUg+Ah2wySiOvbXUyyYhLFqpCTVOpuu/OXfS4kWP7yYTalv5rn FhLetxQyzEAFTLT1Qw9OB0ZCw8C9rUyEMwJb/k1FRQGFf1mSoMPRVf1A3kB0e3JL9MiW CHxb/QGAXTlaxPDsFyJX6e2KNVjwiWJLkpBHOpQ3BxdIHOeoO+CuVFzBWFHYw0h7vf0X p8oVbkms1EKnYwlsozcTS3O26Wm5QZ0QM3PGYRBnEnJA+bNx+WIceea/YAvsBgsUm5Qx WqeMjabrcDXC+NhaqoY7VKzBDZ8n+Naz9Dtxrf4fPvl/nG3uGEgGhTcFKJ6sqpyNEJ4J L20Q== Received: by 10.66.75.228 with SMTP id f4mr87032961paw.52.1342067195537; Wed, 11 Jul 2012 21:26:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.213.197 with HTTP; Wed, 11 Jul 2012 21:26:15 -0700 (PDT) In-Reply-To: <4FFBD95F.6010209@FreeBSD.org> References: <201207042153.q64Lrajj048759@repoman.freebsd.org> <4FF4BDFC.7070604@FreeBSD.org> <85zFQmwqygMzE5IoVEZOBb55NHc@h+Kmx6xuhLPDxlAxgYCP+NijPgY> <4FF95786.2070905@FreeBSD.org> <20120709081324.GB13540@MacBook-Eygene-Ryabinkin.local> <4FFBD95F.6010209@FreeBSD.org> From: Henry Hu Date: Thu, 12 Jul 2012 00:26:15 -0400 Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: ports@freebsd.org, Michael Scheidell , Eygene Ryabinkin Subject: Re: cvs commit: ports/x11/slim Makefile pkg-plist ports/x11/slim/files pam.conf slim.sh.in X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 04:26:37 -0000 I'm testing the patch. First, I failed to build, and the reason is that my cmake is 2.8.3 which is too old. According to http://www.cmake.org/pipermail/cmake-commits/2012-February/012056.html, it seems like that after cmake 2.8.7, find_package(X11) would define X11_Xmu_LIB, but before that, it is defined as GLUT_Xmu_LIBRARY with find_package(GLUT). Do we need to add a build dependency that this depends on cmake >= 2.8.7? It seems like that there is no reference to glut anymore. Its usage was only to find Xmu. So I think that we should remove USE_GL=glut. For the png problem, I think that we can use png_jmpbuf for any libpng >= 1.2.5? It seems to be exist at least from libpng 1.2.5 (http://www.libpng.org/pub/png/libpng-1.2.5-manual.html) so it's safe to use it? According to http://old.nabble.com/png_jmpbuf%28%29-in-libpng-1.4-td30966838.html, someone has problem with png_jmpbuf with libpng 1.4, but it seems like that this is not related. On Tue, Jul 10, 2012 at 3:27 AM, Doug Barton wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 07/09/2012 01:13, Eygene Ryabinkin wrote: >> This very error should be fixed by the patch > > Yes, I'm an idiot. :) I successfully applied your patch and forgot to > move the new patch- file into files/. Once I fixed the PEBKAC it worked > as expected on 10-current amd64, and 8-stable i386. > > Henry, if you'd like me to apply the patch just let me know. Eygene, > thanks for doing this. > > Doug > > - -- > > Change is hard. > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.19 (FreeBSD) > > iQEcBAEBCAAGBQJP+9lfAAoJEFzGhvEaGryEds8H/jVudAimsgQEgJZ1EGWCN7mX > xsjam23cBz5hCAf5ay4cmDkyUbdfSeYJHTQ+WmjuMRKaoKBoyMvKSAbVcvKfOiNr > iOoFWT82D/fXWNW+X/Ny4sqv16FNpP2hQsiEa0E5luPU9bA52wSq6kGU9EiQ+VY6 > JrxwHV8/7MfzaX+g6fRkhwphRYI9bmzK0+evvtMtxEq9dCZTtFcMmGFSwy4EAzT3 > 3mbMYjeWlIsCko+Y/GjtXGlopxiStbMUU32B+O1oKrvtzHJ2Srgi2vZ/B4XVXPSB > W28ANO0AZbqzIUcZvaechXjjcb0mlNKsRnWjlDC4ysheGH6XRjLCEgFH0MZed0I= > =nNUS > -----END PGP SIGNATURE----- -- Cheers, Henry