Date: Sun, 10 Aug 2008 15:21:03 +0300 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: arch@freebsd.org Subject: Re: Need a code review Message-ID: <489EDD2F.9080302@freebsd.org> In-Reply-To: <867iasfmrh.fsf@ds4.des.no> References: <20080729.161303.709402272.imp@bsdimp.com> <86r69buar0.fsf@ds4.des.no> <489B08F6.8060605@freebsd.org> <867iasfmrh.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote:
> Oleksandr Tymoshenko <gonzo@freebsd.org> writes:
>> openpam detects static modules build using cpp(1) condition:
>> #if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES)
>> The problem is that gcc MIPS option -mabi-calls assumes -fpic for both
>> static and dynamic builds. So the question is: would defining
>> NO_STATIC_MODULES for MIPS be enough or it should be addressed
>> upstream?
>
> "upstream" in this case means me.
Here is new fix: http://people.freebsd.org/~gonzo/mips2/libpam2.diff
The idea is to set define explicitly for dynamic case rather then rely on
__PIC__.
--
gonzo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?489EDD2F.9080302>