From owner-freebsd-current@FreeBSD.ORG Sun Mar 25 23:28:47 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A33E016A402 for ; Sun, 25 Mar 2007 23:28:47 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 15A6913C46E for ; Sun, 25 Mar 2007 23:28:46 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 87284 invoked from network); 25 Mar 2007 22:56:59 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 25 Mar 2007 22:56:59 -0000 Message-ID: <460705AE.5040107@freebsd.org> Date: Mon, 26 Mar 2007 01:28:46 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Giorgos Keramidas References: <20070324124732.GA767@nagual.pp.ru> <200703251348.58972.nb_root@videotron.ca> <20070325194946.GC79938@kobe.laptop> <200703251620.20879.nb_root@videotron.ca> <20070325202749.GA1503@kobe.laptop> In-Reply-To: <20070325202749.GA1503@kobe.laptop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, Nicolas Blais Subject: Re: Latest -current complete lockup (tcp changes?) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2007 23:28:47 -0000 Giorgos Keramidas wrote: > Hi Andre, > > The attached thread below is a reply from Nicolas Blais which shows some > problems with the recent SACK changes. Any idea how we can proceed from > this point? Please update to rev. 1.36 of sys/netinet/tcp_sack.c. The KASSERT() was too tight but actually caught a bug that would have caused a crash anyway. -- Andre > - Giorgos > > On 2007-03-25 16:20, Nicolas Blais wrote: >> On March 25, 2007 03:49:46 pm Giorgos Keramidas wrote: >>> On 2007-03-25 13:48, Nicolas Blais wrote: >>>>> The panic happens after a small amount of network activity, inside >>>>> the TCP SACK code: >>>>> >>>>> ----------------------------------------------------------------------- >>>>> ---- Disabling SACK lets me use my laptop again: >>>>> >>>>> net.inet.tcp.sack.enable=0 >>>>> >>>>> without any panics. >>>> Same here. If you want to quickly crash your system, >>>> net.inet.tcp.sack.enable=1 and start a torrent :) >>>> >>>> I couldn't find what was causing my desktop to crash until I STOPPED >>>> trying to restart my torrent after boot :) . Though >>>> net.inet.tcp.sack.enable=0 fixed it. >>> Rebuilding a kernel will take a while here. If you can try reverting >>> the following commit before I do, let me know if it fixes the panic. >>> >>> % andre 2007-03-23 18:33:21 UTC >>> % >>> % FreeBSD src repository >>> % >>> % Modified files: >>> % sys/netinet tcp_input.c tcp_sack.c >>> % Log: >>> % Bring SACK option handling in tcp_dooptions() in line with all other >>> % options and ajust users accordingly. >>> % >>> % Revision Changes Path >>> % 1.326 +7 -4 src/sys/netinet/tcp_input.c >>> % 1.35 +1 -0 src/sys/netinet/tcp_sack.c >> Done. >> >> I reverted tcp_input.c to 1.325 and tcp_sack.c to 1.34. I was able to start >> many torrents without a panic. I believe the revert fixed the problem, as >> previously, just starting 1 torrent would panic (unless >> net.inet.tcp.sack.enable=0) , now I have 5 running fine. >> >> Nicolas. > >