From owner-svn-src-user@FreeBSD.ORG Thu Apr 8 21:27:52 2010 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 123B9106566B; Thu, 8 Apr 2010 21:27:52 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 9057D8FC14; Thu, 8 Apr 2010 21:27:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o38LGheI051992; Thu, 8 Apr 2010 15:16:43 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 08 Apr 2010 15:16:46 -0600 (MDT) Message-Id: <20100408.151646.884721755803198764.imp@bsdimp.com> To: nwhitehorn@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <4BBDE4A5.8090604@freebsd.org> References: <201004080648.o386mKnr042060@svn.freebsd.org> <4BBDE4A5.8090604@freebsd.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jmallett@FreeBSD.org, src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r206392 - user/jmallett/octeon/sys/mips/mips X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2010 21:27:52 -0000 In message: <4BBDE4A5.8090604@freebsd.org> Nathan Whitehorn writes: : On 04/08/10 01:48, Juli Mallett wrote: : > Author: jmallett : > Date: Thu Apr 8 06:48:20 2010 : > New Revision: 206392 : > URL: http://svn.freebsd.org/changeset/base/206392 : > : > Log: : > Hide quad syscall calling convention behind __mips_o32. : > : > Modified: : > user/jmallett/octeon/sys/mips/mips/vm_machdep.c : > : > Modified: user/jmallett/octeon/sys/mips/mips/vm_machdep.c : > ============================================================================== : > --- user/jmallett/octeon/sys/mips/mips/vm_machdep.c Thu Apr 8 06:42:19 : > --- 2010 (r206391) : > +++ user/jmallett/octeon/sys/mips/mips/vm_machdep.c Thu Apr 8 06:48:20 : > 2010 (r206392) : > @@ -265,19 +265,29 @@ cpu_set_syscall_retval(struct thread *td : > { : > struct trapframe *locr0 = td->td_frame; : > unsigned int code; : > +#if defined(__mips_o32) : > int quad_syscall; : > +#endif : > : What about 32-bit O32 compatibility? For PPC64, I wrapped this kind of : code in if (p->p_sysent->sv_flags & SV_ILP32). Right now I don't think we support running binaries that are a different ABI than the kernel ABI. Long term, we'll need to do that. Warner