Date: Mon, 19 Dec 2011 12:52:56 -0700 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yanegomi@gmail.com> Cc: Doug Barton <dougb@FreeBSD.org>, Max Khon <fjoe@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, =?iso-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@t-hosting.hu>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r228143 - in head: . share/mk tools/build/options Message-ID: <0CAA5754-4FAC-4B87-92B7-439B109473C0@bsdimp.com> In-Reply-To: <CAGH67wSn-kGhtW-qVwwEVvmmu076ncAqMXx=42PnWwb3a4cCbg@mail.gmail.com> References: <201111291946.pATJkHMs064094@svn.freebsd.org> <4ED544E1.3050307@t-hosting.hu> <4ED545A9.8000304@FreeBSD.org> <CAGH67wSn-kGhtW-qVwwEVvmmu076ncAqMXx=42PnWwb3a4cCbg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Nov 29, 2011, at 1:53 PM, Garrett Cooper wrote: > 2011/11/29 Doug Barton <dougb@freebsd.org>: >> On 11/29/2011 12:47, G=E1bor K=F6vesd=E1n wrote: >>> On 2011.11.29. 20:46, Max Khon wrote: >>>> Log: >>>> Turn off profiled libs build by default. >>>> Can be enabled back using WITH_PROFILE=3Dyes in /etc/src.conf >>> I think it was useful. Profiling is useful for developing any piece = of >>> software that builds on libc or other common libs, even for software >>> that is not directly related to FreeBSD. I think it should be = reverted. >>=20 >> Since we ask users to read -current, it would be useful if our >> developers did too. :) >>=20 >> As Max pointed out in his message about this, the profiled libs are = only >> really useful to a tiny percentage of developers. If you need them, >> twist the knob. Building them should be off by default. >=20 > +1. The needs of the many outweigh the needs of the few. As suggested > elsewhere, I think it would also be a good idea to enable it in > tinderbox builds. -1. The needs of the many? Please. Let's break a useful feature = because some people don't understand it and are impatient? That's lame. Enabling it only on tinderbox builds will ensure more accidental = breakage. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0CAA5754-4FAC-4B87-92B7-439B109473C0>