Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Mar 2019 15:14:51 +0100
From:      Matthias Fechner <mfechner@freebsd.org>
To:        Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files
Message-ID:  <c60345be-3ca7-5171-23fc-9fa3ab9c1ab0@freebsd.org>
In-Reply-To: <CAMHz58QA8FJKLkmr2BEd4Dz3PNLj_yY=FyMfFjbOkWrZQYxx8Q@mail.gmail.com>
References:  <201903021804.x22I4KBT029443@repo.freebsd.org> <f24ce2de-97a7-da6c-4365-926f9d3cec06@fechner.net> <CAMHz58QA8FJKLkmr2BEd4Dz3PNLj_yY=FyMfFjbOkWrZQYxx8Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO
Content-Type: multipart/mixed; boundary="ebuS6JIluVrXqbULriHoVHddygBmalUkh";
 protected-headers="v1"
From: Matthias Fechner <mfechner@freebsd.org>
To: Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Message-ID: <c60345be-3ca7-5171-23fc-9fa3ab9c1ab0@freebsd.org>
Subject: Re: svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files
References: <201903021804.x22I4KBT029443@repo.freebsd.org>
 <f24ce2de-97a7-da6c-4365-926f9d3cec06@fechner.net>
 <CAMHz58QA8FJKLkmr2BEd4Dz3PNLj_yY=FyMfFjbOkWrZQYxx8Q@mail.gmail.com>
In-Reply-To: <CAMHz58QA8FJKLkmr2BEd4Dz3PNLj_yY=FyMfFjbOkWrZQYxx8Q@mail.gmail.com>

--ebuS6JIluVrXqbULriHoVHddygBmalUkh
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: de-DE

Am 02.03.2019 um 19:59 schrieb Po-Chuan Hsieh:
> Please read=C2=A0ext/nokogiri/extconf.rb or check ports tree history.
>
> As I mentioned in the commit log, we do not need
> mini_portile/mini_portile2.
> It is used to download and build the libraries (libxml2, libxslt,
> zlib) which is already handled by our ports framework very well.
> Furthermore, it is not needed when using system=C2=A0libraries
> (CONFIGURE_ARGS=3D--use-system-libraries) [1][2].
>
> Reference:
> [1]=C2=A0https://github.com/sparklemotion/nokogiri/blob/v1.10.1/ext/nok=
ogiri/extconf.rb#L447-L471
> [2]
> https://nokogiri.org/tutorials/installing_nokogiri.html#install-with-sy=
stem-libraries

Thanks a lot for your answer and explanation!

I'm not really in favor of removing dependency of a port if they are
documented as required.
I understand that is this case you are absolutely sure, that removing
the dependency does not break anything.

But I had in the past the problem that one dependency was missing for a
gem used by gitlab-ce.
Gitlace-ce was running, but it failed on some place. It was a nightmare
to debug this and I do not want to repeat this.
I do not really see, why it is a problem if one port more is installed
with the gem.

If you want to keep the gem patched out of rubygem-nokogiri I suggest to
add a comment in the port to make clear the dep is not missing but was
removed for a good reason.
That will make it much more simple to not forget it in future. ;)

Gru=C3=9F
Matthias

--=20

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook



--ebuS6JIluVrXqbULriHoVHddygBmalUkh--

--qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJce+FcAAoJELaLddyf10fhkvUP/32TgS8oMDaH06XzB4Daf503
PsmzFkQD1k8WQ0dEpEdMuK2F+xu938yXZw0KjToXNm4JR3gtp8d/M3rCxlSxuGKN
6uAj2DxXOZsMaOmQZiJw01HTPVrUXScoXu1w6OlU4spXXnHUIJYtllU398U2IeZ8
c3bPCNDxdh6OvXevtRTdJvv0myQ8d/Lo0U2gcT762EvJ490H4nqlLLKb855cDBS3
QPiBw7Nv6bwa7D7TZiINrUDrL3gbG4lgt2HWVe5nvqwe7atA/1kZ4ikYHdbuNefx
KpmYQNrY44B/xBcvZSPUmHko1kGfvm/rCfHN/c9Sydtgvpnjt2iE4U04xvbvCAbe
Lm7YxzEdBNUfjzG38j20fhjL56hirMRFqQEzETdtm/eX9KCZX/FBhWLq2w9eA/6X
GR8j1xNMCwgudq62zoiH0YFWo7pVQYNXZfkQYB4LEi9lwPJWRDQPypsLEtE93d/J
LUE4dXDirRKHYsa9mUt5/SFL6rFZw07lYAUAGA//C8je2F1lTnJ2Ems2iPK5Lizo
h9iSm4Dm+DS1myejXKVqpW/PybNb4291ajFTWRAMn4n5UU5pVQCq+QBwNKVIjbn3
mb4TMS0aPeYrUav3BRHhUMUnt2ZM/v8pr1/bRNie4051ZCy+xm9uBddUN/SGvaJO
wtsRaV1VUAYYeBkCCUh4
=6jfo
-----END PGP SIGNATURE-----

--qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c60345be-3ca7-5171-23fc-9fa3ab9c1ab0>