From owner-svn-ports-all@freebsd.org Sun Mar 3 14:14:56 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9D0D150BFCA; Sun, 3 Mar 2019 14:14:55 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F1DA865FC; Sun, 3 Mar 2019 14:14:55 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from [IPv6:2a01:5c0:e08e:fc71:b967:eff5:a8db:1f09] (unknown [IPv6:2a01:5c0:e08e:fc71:b967:eff5:a8db:1f09]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id E6BF75EDE; Sun, 3 Mar 2019 14:14:54 +0000 (UTC) (envelope-from mfechner@freebsd.org) Subject: Re: svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201903021804.x22I4KBT029443@repo.freebsd.org> From: Matthias Fechner Openpgp: preference=signencrypt Autocrypt: addr=mfechner@freebsd.org; prefer-encrypt=mutual; keydata= mQINBFqca1YBEADM9mF2+ifk8HILTlf5wtAzV6SYVR4RvNOo/8Kucw4sCZT76zS1fjZe4Zy1 3C0IZ07Wi+3PnoGIgOCsXp3PrTc2nuHQWkwVBYXy8UaR9DHBWA/mIvRGG1ZscKQYA6oUdCvd K8Mu26zO60yTt+ONzFtK6G1myH4EHXZ8dpmdCFf+W3rzTU+aCQ5S3OfwCLGgYgOaVREGkdOc 5SVCpFb4n+2B8+CqeWsRHhnT+4h7/YhgDMGp4GiI3yrB2nBVSUUvcosD2nRtJQgGQHcAFtMq 3hJaKPOR/mHc6KVrp0xmGNmdtazvXloHmGIl9O1UpmMmrYu9Kugl0JkGi2fAcno02XgVlkyX 7xDLTteP5cNqRxor4yVDaRWUQnOfK9XgcrKGrAzb65BkCSkjT+Aw3S/A8Qd6NvjL9qy1d+Ct dzatOVF/Y7jaW28CMr3jvwPS13OxV7PnJzIZzdik20eVxfOXuYfxZD+PwBaGgFF0qj6zKACC aKLalE0ZpY0zNn/iPyQX/Cf9KoDyFpOHSsEswiJ5rCWwppVcsFyogHOemVmeaXlvyDPEipnV ZUkpGP/CCqPu3eD0uDzP7UJ0pt/l/JfW0Xw/4p9mjB024xiRlxLa6vSRfGl//EdtAIbKKa8x 5wsKTQEbYJDmXE3tH/A54DCqRXhcopTlu2iJlTdnIMltn9afVwARAQABtCdNYXR0aGlhcyBG ZWNobmVyIDxtZmVjaG5lckBmcmVlYnNkLm9yZz6JAlQEEwEKAD4WIQRpYHriYKnzThg62q62 i3Xcn9dH4QUCXDNH/AIbAwUJCWYBgAULCQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRC2i3Xc n9dH4W2ED/9rovvF0wEHCSuxn8W5s5qhe9RbvCeBEDuyHsEDMDg6Rg+1T3l/I27AJYIrVGz2 cLvLOWuDZXqZ0Pl5YGK2rOoFx5PMVU4PqP+zmpy4OFjC8fgukYD4L4rsgzTlpC0Aw9kP5/zJ 3clVtr+NY3ETRSsx5NaOOs5WqAM9SvYLzlqnTMxag3N3RvKoGYBm8ykjYc0aJ2qDH4adzeRS ZuS2h5lHPw9sQ/PjZsfaVx2sM52oy6ZmymFqefACGvWmjGAppTSP5ZrKkwDOchpoLEiqk4EO IgR0Uj+e82722mNK33owZ2PFA7HXPa7/JxU+b4liIv/L/zkEKhg55HjeWU+ZysmFcO9Tbym8 qtxN1Iw1zov/nWDZZtwJ4ZlNK+pO1taY+cxpyrrZrlQimoZbkli7WoLyNt1f3bU6OikNyPn7 YNJL0NTRe80DeU+v+MDNJUjcWlq29mAgePN6bSS3IJMB60etWU7bsDt8864FGsabR/QxuX63 +IaPEKJV+DNIA1BV8BAKB48PI0iwS/exVKLL5yGFhZi0H3UPwHwYpH4vd6tUJo6HhbDlpZvX azsD4qF/DGlxbxHaEzdXT8Tmoc/TztEMbb0ypHdnNjuxl4N20YpCu/8YxIESYBL6jX8bo5rF PeHRLa3ryVXbaqebLuenhFS9OSLIke67qUK8iqrQkycrjrkCDQRanGtWARAA3e4IsdkX7VWB yvNiPAvXAAnCNhvtSccq81h1oEqBbSfQ1N9pMIsfEdg87w2VXX6U1y1J5ct6JamYTWUIMer/ 77ncQnfg6xF3+fbjo9218h+W0wvve2yarpL3NPJ7bO/suyYTuOBQFpqxu/SpItLJs5S+RHGP fEG4r1iaD9ldoQ06HHAhDqhCg0uDd6uz23leXg1UrqDPNnY51Mae5RWFCaLits/ThHQYkWEC 0YsBhQLGVdVmF08CziplqgAQ/mdb+7YzLNJoii7BwQh220CI9l2smv5rg4YrPzxKfrOopJq7 JQAOBf4by0pQ42Blt/PhJJG+WKc6DJTZHLJ81L3vuv9h9ocf6gDGDfXJRY+0P+vJ9XDr1sa8 rxFCtn35zW/JYEAGhA6Hn4kdb8AT1ePl1Bq0R9aYY7f78VGjZMiGplBdeXw9b6O0SOSGA4c5 RfkRHNKbqcJw8jD4tSQQg1wtz1vDh+/V45Yh0G4JyQYzitZeQthuqF1LN1Z4KwLS2JCTzHs7 XNdEk4oXishMl3+pffbYQfb0FH5P1XUfDssNJF77djG2heFE5lFeMXxCeIQd4pU1FQKiavqt Yaa4eOw1NDu3C3CcbzFI58KRgCn0atvMGQhhf5UW8VAupUz4i3dECWB79vClk++SvdsWwmTg lL4QC6AEis/TF30Ew6HoSPkAEQEAAYkCPAQYAQoAJhYhBGlgeuJgqfNOGDrarraLddyf10fh BQJanGtWAhsMBQkJZgGAAAoJELaLddyf10fhlmwQAKhAjXT2G2mFV7YBCEnvC4+jykitIUDQ xvSl+Jtf+xjDxlnP/Hdy1MjcCOrZtpJqh5si5TJ3qg8jtwDOAvizbMeJncKEfZ0PEmU49+Q5 qIrXbgMkw+paJa7F7f22Crbe2w+HBy8X4ML5KQmgtYoJg0LTp9LdsuS1nSziVUTm2p8vnDAy /GDEH7r6xYfBlZK/UjAH+B6i/rOQSFV2ReqsY8TnYvIt9TQAIyaKFyXT+emwIxlKWzS6uB4K w8y4c9CeZwzYRFt6t7yL050pAPMYGtNtaX0PE1F/ij5wBiKsQkzcpz5kPZITfhtNK+DeR1BB lBuP6j4FFyxHQtoZs5GQ1oxmWnk65e14vqcbuxsA+fRuNRSW6nwIkRcNcQ0boskbX+hVYWqb c60/KvlSgxAC6G4bHT86boBcqv+aT6966gpYxeSqWXTjn9tgTttfYDSCTIYTkN2NqIc+ZL02 xa4oN4TEuVdk4vUZf48qNYsAPCW/TtccHwd/pTT+Wl/f+aCBG2ofIpse3SJGphowL3mBV0yt u6DGHrVT/PEhrB5TtWiUPlxGuW3Go+nmzM7APPDjYljBulixcUlc2S4IYKYrUsdxKF8SCC19 XeD8krO81FCfqnV/R+ummX95nlS9ZUqs0REnNxmCQ55zHCIr8v8mgakZ9Y6pYaxPF78CdBxf GPwP Message-ID: Date: Sun, 3 Mar 2019 15:14:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO" X-Rspamd-Queue-Id: 7F1DA865FC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.88)[-0.878,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 14:14:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO Content-Type: multipart/mixed; boundary="ebuS6JIluVrXqbULriHoVHddygBmalUkh"; protected-headers="v1" From: Matthias Fechner To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: Subject: Re: svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files References: <201903021804.x22I4KBT029443@repo.freebsd.org> In-Reply-To: --ebuS6JIluVrXqbULriHoVHddygBmalUkh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: de-DE Am 02.03.2019 um 19:59 schrieb Po-Chuan Hsieh: > Please read=C2=A0ext/nokogiri/extconf.rb or check ports tree history. > > As I mentioned in the commit log, we do not need > mini_portile/mini_portile2. > It is used to download and build the libraries (libxml2, libxslt, > zlib) which is already handled by our ports framework very well. > Furthermore, it is not needed when using system=C2=A0libraries > (CONFIGURE_ARGS=3D--use-system-libraries) [1][2]. > > Reference: > [1]=C2=A0https://github.com/sparklemotion/nokogiri/blob/v1.10.1/ext/nok= ogiri/extconf.rb#L447-L471 > [2] > https://nokogiri.org/tutorials/installing_nokogiri.html#install-with-sy= stem-libraries Thanks a lot for your answer and explanation! I'm not really in favor of removing dependency of a port if they are documented as required. I understand that is this case you are absolutely sure, that removing the dependency does not break anything. But I had in the past the problem that one dependency was missing for a gem used by gitlab-ce. Gitlace-ce was running, but it failed on some place. It was a nightmare to debug this and I do not want to repeat this. I do not really see, why it is a problem if one port more is installed with the gem. If you want to keep the gem patched out of rubygem-nokogiri I suggest to add a comment in the port to make clear the dep is not missing but was removed for a good reason. That will make it much more simple to not forget it in future. ;) Gru=C3=9F Matthias --=20 "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --ebuS6JIluVrXqbULriHoVHddygBmalUkh-- --qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJce+FcAAoJELaLddyf10fhkvUP/32TgS8oMDaH06XzB4Daf503 PsmzFkQD1k8WQ0dEpEdMuK2F+xu938yXZw0KjToXNm4JR3gtp8d/M3rCxlSxuGKN 6uAj2DxXOZsMaOmQZiJw01HTPVrUXScoXu1w6OlU4spXXnHUIJYtllU398U2IeZ8 c3bPCNDxdh6OvXevtRTdJvv0myQ8d/Lo0U2gcT762EvJ490H4nqlLLKb855cDBS3 QPiBw7Nv6bwa7D7TZiINrUDrL3gbG4lgt2HWVe5nvqwe7atA/1kZ4ikYHdbuNefx KpmYQNrY44B/xBcvZSPUmHko1kGfvm/rCfHN/c9Sydtgvpnjt2iE4U04xvbvCAbe Lm7YxzEdBNUfjzG38j20fhjL56hirMRFqQEzETdtm/eX9KCZX/FBhWLq2w9eA/6X GR8j1xNMCwgudq62zoiH0YFWo7pVQYNXZfkQYB4LEi9lwPJWRDQPypsLEtE93d/J LUE4dXDirRKHYsa9mUt5/SFL6rFZw07lYAUAGA//C8je2F1lTnJ2Ems2iPK5Lizo h9iSm4Dm+DS1myejXKVqpW/PybNb4291ajFTWRAMn4n5UU5pVQCq+QBwNKVIjbn3 mb4TMS0aPeYrUav3BRHhUMUnt2ZM/v8pr1/bRNie4051ZCy+xm9uBddUN/SGvaJO wtsRaV1VUAYYeBkCCUh4 =6jfo -----END PGP SIGNATURE----- --qQonPSsWD1p0MazW7uqw7mFof1PtPsWIO--