Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Jul 2011 16:13:23 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Daniel Gerzo <danger@FreeBSD.org>
Cc:        Luka Lalinsky <lalinsky@gmail.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www/uwsgi Makefile ports/www/uwsgi/files uwsgi.in
Message-ID:  <4E2DF893.5090701@FreeBSD.org>
In-Reply-To: <201107251615.p6PGFoVv069376@repoman.freebsd.org>
References:  <201107251615.p6PGFoVv069376@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I've run out of new and creative ways to say, "don't do this":

+: ${uwsgi_profiles=""}

There is absolutely no reason to do it, and so it should not be done.

Also, the whole if/then block that's in the script unconditionally now
should be enclosed in a function, probably start_precmd but it looks
like it's probably necessary for the restart stuff too, so a generic
name that is referenced from *_precmd should be fine.


Doug


On 07/25/2011 09:15, Daniel Gerzo wrote:
> danger      2011-07-25 16:15:50 UTC
> 
>   FreeBSD ports repository (doc committer)
> 
>   Modified files:
>     www/uwsgi            Makefile 
>     www/uwsgi/files      uwsgi.in 
>   Log:
>   - install uwsgidecorators.py as well [1]
>   - improve the rc.d script - allow multiple instances etc (see PR) [2]
>   
>   PR:             ports/156723 [2]  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=156723
>   Submitted by:   Luka Lalinsky <lalinsky@gmail.com> [2]
>   Requested by:   Attila Nagy <bra@fsn.hu> [1]
>   
>   Revision  Changes    Path
>   1.13      +4 -1      ports/www/uwsgi/Makefile
>   1.3       +59 -5     ports/www/uwsgi/files/uwsgi.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/uwsgi/Makefile.diff?&r1=1.12&r2=1.13&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/uwsgi/files/uwsgi.in.diff?&r1=1.2&r2=1.3&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E2DF893.5090701>