From owner-cvs-ports@FreeBSD.ORG  Mon Jul 25 23:13:24 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id E70F410656A3;
	Mon, 25 Jul 2011 23:13:24 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org
	[IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 3C473157713;
	Mon, 25 Jul 2011 23:13:24 +0000 (UTC)
Message-ID: <4E2DF893.5090701@FreeBSD.org>
Date: Mon, 25 Jul 2011 16:13:23 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:5.0) Gecko/20110723 Thunderbird/5.0
MIME-Version: 1.0
To: Daniel Gerzo <danger@FreeBSD.org>
References: <201107251615.p6PGFoVv069376@repoman.freebsd.org>
In-Reply-To: <201107251615.p6PGFoVv069376@repoman.freebsd.org>
X-Enigmail-Version: 1.2pre
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Luka Lalinsky <lalinsky@gmail.com>, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/uwsgi Makefile ports/www/uwsgi/files
	uwsgi.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jul 2011 23:13:25 -0000

I've run out of new and creative ways to say, "don't do this":

+: ${uwsgi_profiles=""}

There is absolutely no reason to do it, and so it should not be done.

Also, the whole if/then block that's in the script unconditionally now
should be enclosed in a function, probably start_precmd but it looks
like it's probably necessary for the restart stuff too, so a generic
name that is referenced from *_precmd should be fine.


Doug


On 07/25/2011 09:15, Daniel Gerzo wrote:
> danger      2011-07-25 16:15:50 UTC
> 
>   FreeBSD ports repository (doc committer)
> 
>   Modified files:
>     www/uwsgi            Makefile 
>     www/uwsgi/files      uwsgi.in 
>   Log:
>   - install uwsgidecorators.py as well [1]
>   - improve the rc.d script - allow multiple instances etc (see PR) [2]
>   
>   PR:             ports/156723 [2]  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=156723
>   Submitted by:   Luka Lalinsky <lalinsky@gmail.com> [2]
>   Requested by:   Attila Nagy <bra@fsn.hu> [1]
>   
>   Revision  Changes    Path
>   1.13      +4 -1      ports/www/uwsgi/Makefile
>   1.3       +59 -5     ports/www/uwsgi/files/uwsgi.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/uwsgi/Makefile.diff?&r1=1.12&r2=1.13&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/uwsgi/files/uwsgi.in.diff?&r1=1.2&r2=1.3&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/