Date: Sat, 11 Mar 2017 18:30:37 -0700 From: Adam Weinberger <adamw@adamw.org> To: Matthew Rezny <rezny@freebsd.org> Cc: Tijl Coosemans <tijl@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, swills@freebsd.org, gnome@freebsd.org Subject: Re: svn commit: r435961 - in head/www/webkit-gtk2: . files Message-ID: <96D05335-EC74-4CD0-9F00-95CC02B62CF8@adamw.org> In-Reply-To: <1651531.nGg9pBWiG5@workstation.reztek> References: <201703112115.v2BLF3qk062113@repo.freebsd.org> <20170312001958.6e8fdd4b@kalimero.tijl.coosemans.org> <1651531.nGg9pBWiG5@workstation.reztek>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 11 Mar, 2017, at 17:36, Matthew Rezny <rezny@freebsd.org> wrote: >=20 > On Sunday 12 March 2017 00:19:58 Tijl Coosemans wrote: >> On Sat, 11 Mar 2017 21:15:03 +0000 (UTC) Matthew Rezny >>=20 >> <rezny@FreeBSD.org> wrote: >>> Author: rezny >>> Date: Sat Mar 11 21:15:03 2017 >>> New Revision: 435961 >>> URL: https://svnweb.freebsd.org/changeset/ports/435961 >>>=20 >>> Log: >>> - Fix building on PPC/PPC64 [1] >>> - Fix building on ARMv6 [2] >>> - Add missing indirect dependencies >>=20 >> You should never add the dependencies of another port to your port >> because if that other port ever changes dependencies your port will = still >> pull them in. If you are getting warnings about missing dependencies = and >> you know they are indirect then you know there's a problem with one = of >> the other dependencies of your port. The problem needs to fixed = there. >> In this case it's probably because of gnome related pkg-config files. >> These dependencies need to be added to Mk/Uses/gnome.mk. >>=20 >>> - Possibly fix build on sparc64 (unconfirmed) >>>=20 >>> PR: 212903 [1] >>> Submitted by: jhibbits [1], strejda [2] >>> Approved by: swills (mentor) >=20 > I completely agree with that from a technical position. When stage-qa = started=20 > complaining about indirect dependencies, I initially ignored them as = it looked=20 > like an obvious error in the script. Surely, actual dependencies can = be=20 > calculated recursively taking options into account. However, through = both the=20 > actions taken on the PRs submitted at the time and direct statements = when I=20 > questioned the situation, I was informed that the indirect = dependencies should=20 > be added. I think it is completely unproductive and incorrect, but I = had more=20 > important things to do than press the issue. I would be happy to = cease adding=20 > indirect dependencies, which not only depend on the port's options but = the=20 > options of the ports it depends upon, and the options of the ports = those=20 > depend upon and so on. Has there been a change of policy and if so = when can we=20 > expect to see a fixed stage-qa? It'll take some time to undo all the = damage. The policy is that dependencies need to be listed; that clearly hasn't = changed. Is there any indication that stage-qa is broken? Tijl is = completely correct, if the problem is that Uses/gnome.mk isn't listing = all its dependencies, then it needs to be fixed, not stage-qa. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96D05335-EC74-4CD0-9F00-95CC02B62CF8>