Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 May 2019 13:30:33 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r501786 - head/Mk
Message-ID:  <201905161330.x4GDUXHM072250@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tobik
Date: Thu May 16 13:30:33 2019
New Revision: 501786
URL: https://svnweb.freebsd.org/changeset/ports/501786

Log:
  Mk/bsd.sanity.mk: Prevent false positive with SSL_DEFAULT!=base after r499267
  
  With SSL_DEFAULT!=base USES=ssl sets OPENSSL_LDFLAGS and any port with an
  OPENSSL option like net/haproxy gets a false positive error like:
  
  /!\ haproxy-1.9.8: Makefile errors /!\
  
  The following options helpers are incorrectly set after bsd.port.options.mk
  and are ineffective: OPENSSL_LDFLAGS
  
  *** Error code 1
  
  Whitelist OPENSSL_LDFLAGS to prevent this.
  
  Reported by:	mfechner (via ports-committers)
  Approved by:	portmgr (mat)
  Differential Revision:	https://reviews.freebsd.org/D20275

Modified:
  head/Mk/bsd.sanity.mk

Modified: head/Mk/bsd.sanity.mk
==============================================================================
--- head/Mk/bsd.sanity.mk	Thu May 16 13:02:04 2019	(r501785)
+++ head/Mk/bsd.sanity.mk	Thu May 16 13:30:33 2019	(r501786)
@@ -168,6 +168,8 @@ DEV_ERROR+=	"PORT${_type} does not do anything unless 
 .  endif
 .endfor
 
+# Whitelist of options helper lookalikes that should not be reported on:
+_OPTIONS_HELPERS_SEEN+=	OPENSSL_LDFLAGS
 _BROKEN_OPTIONS_HELPERS=
 .for opt in ${_REALLY_ALL_POSSIBLE_OPTIONS}
 .  for helper in ${_ALL_OPTIONS_HELPERS}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905161330.x4GDUXHM072250>