From owner-freebsd-questions@FreeBSD.ORG Sat Dec 3 17:04:15 2005 Return-Path: X-Original-To: freebsd-questions@freebsd.org Delivered-To: freebsd-questions@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 741BC16A41F for ; Sat, 3 Dec 2005 17:04:15 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0071843D78 for ; Sat, 3 Dec 2005 17:04:12 +0000 (GMT) (envelope-from ringworm01@gmail.com) Received: by xproxy.gmail.com with SMTP id t12so609730wxc for ; Sat, 03 Dec 2005 09:04:10 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=i5J18QhMOXWoYAwvy+LII1hVIXWRQS79r+XxhBi0jEdGFyuGsu5swisG53poJYyH5pWExEFpl9ZWV/oOmrCWqy5UVzxPVgp/knEdhy5KdLGW/w6SiCpZBWX0f62kW7LTFKgUqD1ZzIajpon+xJQ5m69Nrk0d1mTJ+nPRXZXYEOQ= Received: by 10.70.9.1 with SMTP id 1mr145086wxi; Sat, 03 Dec 2005 09:04:10 -0800 (PST) Received: from ringworm.mechee.com ( [71.102.14.129]) by mx.gmail.com with ESMTP id h13sm1473692wxd.2005.12.03.09.04.09; Sat, 03 Dec 2005 09:04:10 -0800 (PST) From: "Michael C. Shultz" To: freebsd-questions@freebsd.org, Daniel Bye Date: Sat, 3 Dec 2005 09:04:06 -0800 User-Agent: KMail/1.8.3 References: <20051203152503.GC35163@catflap.slightlystrange.org> <200512030834.46493.ringworm01@gmail.com> <20051203164802.GF35163@catflap.slightlystrange.org> In-Reply-To: <20051203164802.GF35163@catflap.slightlystrange.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200512030904.06988.ringworm01@gmail.com> Cc: Subject: Re: pkgtools-to-portmanager.rb X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2005 17:04:15 -0000 On Saturday 03 December 2005 08:48, Daniel Bye wrote: > On Sat, Dec 03, 2005 at 08:34:45AM -0800, Michael C. Shultz wrote: > > I thank you for your effort! Need to make sure that both formats convert > > BTW: > > > > both of these should be allowed, right now only the top method works: > > > > 'editors/openoffice*' => 'LOCALIZED_LANG=en-US WITH_KDE=1', > > 'emulators/qemu' => [ > > 'WITH_KQEMU=1', > > 'WITH_SOMETHING=1', > > ], > > > > -Mike > > Yep, the new patch handles both - I use both formats in my pkgtools.conf > file, and the created file is correct. For example: > > MAKE_ARGS = { > 'www/mod_php4*' => [ > 'WITH_BZIP2=yes', > 'WITH_CTYPE=yes', > 'WITH_MYSQL=yes', > 'WITH_OVERLOAD=yes', > 'WITH_PCRE=yes', > 'WITH_POSIX=yes', > 'WITH_SESSION=yes', > 'WITH_TOKENIZER=yes', > 'WITH_XML=yes', > 'WITH_ZLIB=yes', > 'WITH_GETTEXT=yes', > 'WITH_ICONV=yes', > 'WITH_IMAP=yes', > 'WITH_MCRYPT=yes', > 'WITH_MHASH=yes', > 'WITH_OPENSSL=yes', > 'WITH_OPENLDAP=yes', > ], > 'textproc/ispell*' => 'ISPELL_BRITISH=yes', > 'mail/exim*' => [ > 'WITH_MYSQL=1', > ], > 'net/samba*' => [ > 'BATCH=yes', > 'WITH_UTMP=yes', > 'WITH_SYSLOG=yes', > 'WITHOUT_CUPS=yes', > 'WITH_RECYCLE=yes', > ], > 'courier-imap*' => 'WITH_MYSQL=1', > 'mail/courier-authlib*' => 'WITH_MYSQL=1', > } > > converts to: > > mail/courier-authlib*|WITH_MYSQL=1 | > courier-imap*|WITH_MYSQL=1 | > www/mod_php4*|WITH_BZIP2=yes WITH_CTYPE=yes WITH_MYSQL=yes > WITH_OVERLOAD=yes WIT H_PCRE=yes WITH_POSIX=yes WITH_SESSION=yes > WITH_TOKENIZER=yes WITH_XML=yes WITH_ ZLIB=yes WITH_GETTEXT=yes > WITH_ICONV=yes WITH_IMAP=yes WITH_MCRYPT=yes WITH_MHAS H=yes > WITH_OPENSSL=yes WITH_OPENLDAP=yes | > net/samba*|BATCH=yes WITH_UTMP=yes WITH_SYSLOG=yes WITHOUT_CUPS=yes > WITH_RECYCLE =yes | > mail/exim*|WITH_MYSQL=1 | > textproc/ispell*|ISPELL_BRITISH=yes | > > I can foresee problems with this default entry in pkgtools.conf: > > AFTERINSTALL = { > '*' => proc { |origin| > cmd_restart_rc(origin) > }, > } > > > It converts to this: > > START|/* #| > > And my guess would be that, as the Ruby instance that creates the file > has gone away, the address of the Proc object will be freed. Dunno what > you want to do about that one. > > Cheers, > > Dan START|/* #| isn't a problem, it ends up being ignored because |/* # doesn't convert to a ports directory. I just tested your patch, works perfect! Saves me from having to learn ruby for another while yet, thanks much! I'm testing another bug fix reported by someone else so when done with that I'll include this so it will be in version 0.3.9_6. Should be in the ports tree tonight but I'll send you a patch to drop into portmanager/files just in case it takes awhile to get into the ports tree. -Mike