From owner-dev-commits-ports-all@freebsd.org Fri Jun 4 18:55:07 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3B01C65335C; Fri, 4 Jun 2021 18:55:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FxX570ycjz4fRq; Fri, 4 Jun 2021 18:55:07 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622832907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DSbNI47VJMzOapn2jSfo8LLMM/kuRm72zc7R8AyLhVE=; b=oCdQs6we8Kn5LfBccPQ9MjCmFgM+7XO+xTLkA//aOKPBLdbLIeZYtsZv6+oYQtcXmCVZyr reSTw4550DRjNN8MZGcBScnFQFwJptNOjoSzzIVPMl00hmgk7rwfcZ4m7GX2rJ4gjEKLjc ihZGHA85E948doj9HcM5nMhHiiOpjGaG89qS6ni2DcwFfjwOybl0beQjnt981CM+MXPHa2 Y+luFHB0EVFMvjiIq72h0SqdVr97ZPQRTZ8dYffOcmqCCTSOWki35UXzDpaaYatP8g2C2O Q04LpY+UeJyd8wl0Pz0ppL3iu76N3gWm9p3UhfnAjtKnSPuqVyrDwTHvYrId9w== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 0080A1E31E; Fri, 4 Jun 2021 18:55:06 +0000 (UTC) Date: Fri, 4 Jun 2021 18:55:06 +0000 From: Alexey Dokuchaev To: Tobias Kortkamp Cc: Piotr Kubaj , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f75b9b72e5cb - main - games/fheroes2: look for libpng without suffix, switch to PORTDOCS Message-ID: References: <202106041251.154Cp68Z089802@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1622832907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DSbNI47VJMzOapn2jSfo8LLMM/kuRm72zc7R8AyLhVE=; b=O9w9/aIyuXw0OOniIWbcGCSRDshoeQQdO/vXWP7rDtcF6TkpG73g+CJj597L5gvlSmD19m Prv1ttdXhMLY8KS+xb03WmmYKeVYMCyf2Xy2+GLrcJOmMr7vvwifwbXqBm38u22fbU5vqu D5PEqoH+p26GboAi9FA94i/xWyRdQfMsV1wfOEhus78lLbX/xweN60pYc/KyO2RlDiiQfo cg2Gd7sU9gXn+/iYceyfpZl1SWPyAGMMTWguPe0iHysG2W3xkrBZAZLNG7+J82Az+YCLoE 9iccm1H3mjS7bFTHYJ/eLSR2UBISPeJl5uw8WbxO06bWfO1HIIDfPjucfHvsIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1622832907; a=rsa-sha256; cv=none; b=Tn1IeNaddaZFG+Ykoj+E+ydjVi9m28/L9Svb6CYDxUOO0eeHOeMFUkOy3/3dqb2cXUb742 2et2ETUIPS5qIhtKh+Dm+xjvGTfKNjeFiSArMwg3BXhe569KywM8eie+Po5GbF3IRrfMDe Tbr40osS9R+p8mraolcJ3EIjNjuPzyitJ0KkC3m7xUQvhm1EkkCQWLU3E0lyhypBAV+xXO IxN+GJvkKDTHItxPHT4B0KRDbWgCTSIOyDXqCBKpnl589absJhh+R66t5YnMMheWQSePdn HyW1ePcAvCyTnw9sA9KfGmLcMftCk+/lgvNg7TxC3b5lfcvj4JRbaldGlDsK5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 18:55:07 -0000 On Fri, Jun 04, 2021 at 08:49:34PM +0200, Tobias Kortkamp wrote: > On Fri, Jun 04, 2021 at 12:51:06PM +0000, Piotr Kubaj wrote: > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f75b9b72e5cb7ac631cf10f936d185ecd434ad72 > > > > commit f75b9b72e5cb7ac631cf10f936d185ecd434ad72 > > Author: Piotr Kubaj > > AuthorDate: 2021-06-04 12:50:57 +0000 > > Commit: Piotr Kubaj > > CommitDate: 2021-06-04 12:50:57 +0000 > > > > games/fheroes2: look for libpng without suffix, switch to PORTDOCS > > I think this is missing > > Reported by: danfe It's okay, I'm not hunting for extra attribution, just for better code. > > -PLIST_FILES= bin/${PORTNAME} \ > > - ${DOCSDIR}/README.txt \ > > +PLIST_FILES= bin/${PORTNAME} > > +PORTDOCS= ${DOCSDIR}/README.txt \ > > ${DOCSDIR}/changelog.txt > > This won't work. Files in PORTDOCS are relative to ${DOSCDIR} so > you need to drop ${DOCSDIR}/. Also PORTDOCS won't do anything > without adding a DOCS option. Yes, I've also noticed that while on the bus (via phone) so could not reply. Thanks for following up Tobias. ./danfe