Date: Mon, 22 Aug 2016 12:57:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205191] mail/dcc-dccd: Fails stage-qa Message-ID: <bug-205191-13-0ldusOqmL7@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-205191-13@https.bugs.freebsd.org/bugzilla/> References: <bug-205191-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205191 --- Comment #19 from John Marino <marino@FreeBSD.org> --- Piotr, Yuri's patch isn't good. The first part of the patch, the stripping, is done better by John Hein's patch. The second part of the patch, is attempted to break the detection for libed= it. 1) The method to this this is a complete hack, that can be done by setting CONFIGURE_ARG+=3D ac_cv_header_histedit_h=3Dno 2) It removes the functionality that libedit would provide It appears your criteria for "good" is that the error message goes away, bu= t I don't share the same opinion on the patch. I would start by changing the configure script to add -L$(prefix)/lib before -ledit and changing -ltermcap to -lncurses and I would use John's patch to= fix the stripping. Let's fix the actual problem, rather than cripple this to satisfy a qa message. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205191-13-0ldusOqmL7>