From owner-svn-src-all@freebsd.org Sat Apr 27 15:23:09 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 970F81595679; Sat, 27 Apr 2019 15:23:09 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id ECB5089516; Sat, 27 Apr 2019 15:23:08 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 75f35a9e; Sat, 27 Apr 2019 17:23:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=Iup1rIuLlWa1 CBEJDkG54lpj9qQ=; b=O3tVd3hrjWJ+lYWjWlIbfn9ioXGiRUb1/w3bnRUfS90e tVv+aSF+ibzPjuS6oouuAGA14gHTO69qE8RXfQsvEReMOKc5im00Z3LzCv9z3IaP axDuS9bhi560nmVeu1QhCjX/NkcRartGjNFXbNMB8Ll2FDZm65iUB0lj53UDpzg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=JIfDcO FgRW3QwJORVmqPjVveWAurg1TZ2yYobsJHgs6h6HQUHDS54Q+xlUGzo+hf5OJaCd oGc5OadsdH/BmUFmXn9oIKHmcNMqZdZOHveKAmaJfiIB4lpkRrE3g4HfoIOZz8Gi FBdPeCz8ldl+d5xLOQzEljK+OTv9QLbWuNQDM= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 55d5dd0e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Sat, 27 Apr 2019 17:23:00 +0200 (CEST) Date: Sat, 27 Apr 2019 17:23:00 +0200 From: Emmanuel Vadot To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346788 - head/sys/arm/allwinner/clkng Message-Id: <20190427172300.eee4575d5a4049b5b11de741@bidouilliste.com> In-Reply-To: <201904271456.x3REuOtV097621@repo.freebsd.org> References: <201904271456.x3REuOtV097621@repo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ECB5089516 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Apr 2019 15:23:09 -0000 On Sat, 27 Apr 2019 14:56:24 +0000 (UTC) Emmanuel Vadot wrote: > Author: manu > Date: Sat Apr 27 14:56:24 2019 > New Revision: 346788 > URL: https://svnweb.freebsd.org/changeset/base/346788 >=20 > Log: > arm64: allwinner: ccu_de2: Remove H5 compatible > =20 > We don't have the display engine driver commited in FreeBSD yet so it is > useless to expose the clocks yet (and also it have not been tested on H= 5). My initial though were wrong. I though I've never tested the clocks on H5 but I did (but the full display engine wasn't tested). What happened is that since r346271 aw_rtc now attaches at BUS_PASS_BUS + MIDDLE as it exposes clocks used by the ccu (clock and control unit) and the CCU attaches at BUS_PASS_BUS + LAST which is the same bus pass as the de2_ccu. Since the de2ccu node is before the ccu node in the DTB it is processed first. A proper fix would be to check if the needed clocks are already registed in the probe function. And this I guess a lots of driver will need this I'll see how to make a generic function that drivers could use. =20 > Reported by: Manuel St=FChn (freebsdnewbie@freenet.de) > PR: 237571 > MFC after: 1 week >=20 > Modified: > head/sys/arm/allwinner/clkng/ccu_de2.c >=20 > Modified: head/sys/arm/allwinner/clkng/ccu_de2.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/arm/allwinner/clkng/ccu_de2.c Sat Apr 27 14:48:27 2019 (r346= 787) > +++ head/sys/arm/allwinner/clkng/ccu_de2.c Sat Apr 27 14:56:24 2019 (r346= 788) > @@ -115,7 +115,6 @@ static struct aw_ccung_clk de2_ccu_clks[] =3D { > =20 > static struct ofw_compat_data compat_data[] =3D { > {"allwinner,sun50i-a64-de2-clk", 1}, > - {"allwinner,sun50i-h5-de2-clk", 1}, > {NULL, 0} > }; > =20 --=20 Emmanuel Vadot