Date: Thu, 21 Aug 2014 23:06:16 +0100 From: Vsevolod Stakhov <vsevolod@FreeBSD.org> To: Matthias Andree <mandree@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r365596 - head/math/gringo/files Message-ID: <53F66D58.6040702@FreeBSD.org> In-Reply-To: <53F66B12.6040404@FreeBSD.org> References: <201408212040.s7LKeqJ0075659@svn.freebsd.org> <53F65A20.8070806@FreeBSD.org> <53F66B12.6040404@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21.08.2014 22:56, Matthias Andree wrote: > Am 21.08.2014 um 22:44 schrieb Matthias Andree: >> Am 21.08.2014 um 22:40 schrieb Matthias Andree: >>> Author: mandree >>> Date: Thu Aug 21 20:40:52 2014 >>> New Revision: 365596 >>> URL: http://svnweb.freebsd.org/changeset/ports/365596 >>> QAT: https://qat.redports.org/buildarchive/r365596/ >>> >>> Log: >>> Test fix for math/gringo. >>> >>> Added: >>> head/math/gringo/files/ >>> head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp (contents, props changed) >>> >>> Added: head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp >>> ============================================================================== >>> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >>> +++ head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp Thu Aug 21 20:40:52 2014 (r365596) >>> @@ -0,0 +1,12 @@ >>> +--- ./libprogram_opts/src/string_convert.cpp.orig 2014-08-12 17:47:21.000000000 +0200 >>> ++++ ./libprogram_opts/src/string_convert.cpp 2014-08-21 22:39:08.000000000 +0200 >>> +@@ -28,6 +28,9 @@ >>> + } >>> + #endif >>> + #endif >>> ++namespace std { >>> ++ using ::strtoull; >>> ++} >>> + namespace bk_lib { >>> + >>> + static int detectBase(const char* x) { >>> >> >> Whoops, I meant to commit this to redports but ran the commit from the >> wrong working directory, so it hit the official ports tree. Sorry for >> that. I'll let redports do its job, and if there's anything wrong, >> revert, else I'll let it live. >> >> This is meant to fix >> http://package20.nyi.freebsd.org/data/91amd64-default-baseline/365523/logs/errors/gringo-4.4.0_1.log >> > > The fix above works on 9.x, but not on 8.4 (per redports), but I cannot > seem to figure out why strtoull() does not get exposed there. I might > try forcing __BSD_SOURCE or other tricks on the source, but the > turnaround time on redports is prohibitive (> 20 min) and I no longer > have 8.x systems around nor would I care to install a new VM for that. > > As I'm not using the port actively, I'll leave it fixed on 9.x for now > with the commit above, but leave it to Vsevolod as maintainer, or > volunteers, to fix this on 8.x, too. > According to http://en.cppreference.com/w/cpp/string/byte/strtoul, std::strtoull is c++11 option. Hence, this port likely requires to use compiler:c++11-lib as well. I'll check this assumption tomorrow. -- Vsevolod Stakhov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53F66D58.6040702>