From owner-cvs-src@FreeBSD.ORG Mon Oct 18 19:55:00 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 65E0816A4CE; Mon, 18 Oct 2004 19:55:00 +0000 (GMT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE0B343D54; Mon, 18 Oct 2004 19:54:59 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.13.1/8.13.1) with ESMTP id i9IJswDp002801; Mon, 18 Oct 2004 12:54:58 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i9IJsw66002800; Mon, 18 Oct 2004 12:54:58 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Oct 2004 12:54:58 -0700 From: "David O'Brien" To: Ruslan Ermilov Message-ID: <20041018195458.GA2457@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com> <20041018180319.GD89681@ip.net.ua> <20041018190044.GA89411@hub.freebsd.org> <20041018192417.GE89681@ip.net.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041018192417.GE89681@ip.net.ua> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2004 19:55:00 -0000 On Mon, Oct 18, 2004 at 10:24:17PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 07:00:47PM +0000, David O'Brien wrote: > > On Mon, Oct 18, 2004 at 09:03:20PM +0300, Ruslan Ermilov wrote: > > > On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > > > > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > > > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > > > > obrien 2004-10-18 17:19:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > > > > lib/libc/i386/net htonl.S ntohl.S > > > > > > Log: > > > > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. .. > > Taking > > Revision Changes Path > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > > > specifically what patch do you suggest that we used in cases like this > > rather than #ifdef I386_CPU". And how to use it? That is one in which > > someone checks out the source and wants to build a userland that is > > usable on an I386 machine. > > I thought I already made it clear, seems not. Not clear enough that I was 100% sure how to make you happy. I386_CPU needs to be userland land global so we establish the a normal way of doing this. What do you think of this patch? Index: /usr/src/share/mk/bsd.cpu.mk =================================================================== RCS file: /home/ncvs/src/share/mk/bsd.cpu.mk,v retrieving revision 1.44 diff -u -r1.44 bsd.cpu.mk --- /usr/src/share/mk/bsd.cpu.mk 17 Oct 2004 05:19:45 -0000 1.44 +++ /usr/src/share/mk/bsd.cpu.mk 18 Oct 2004 19:51:17 -0000 @@ -100,6 +100,9 @@ . else _ICC_CPUCFLAGS = . endif # ICC on 'i386' +. if ${CPUTYPE} == "i386" +CFLAGS += -DI386_CPU +. endif . elif ${MACHINE_ARCH} == "alpha" _CPUCFLAGS = -mcpu=${CPUTYPE} . elif ${MACHINE_ARCH} == "amd64" -- -- David (obrien@FreeBSD.org)