Date: Thu, 16 Jul 2015 11:20:53 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Dmitry Marakasov <amdmi3@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla Message-ID: <20150716092053.GX37597@ivaldir.etoilebsd.net> In-Reply-To: <20150716091021.GW37597@ivaldir.etoilebsd.net> References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org> <F55E1B42FC419AF2D5795884@atuin.in.mat.cc> <20150716014306.GA68880@FreeBSD.org> <20150716091021.GW37597@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--m3EZO/+NOdcYnaJL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Jul 16, 2015 at 11:10:22AM +0200, Baptiste Daroussin wrote:
> On Thu, Jul 16, 2015 at 01:43:06AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Jul 15, 2015 at 10:38:33PM +0200, Mathieu Arnold wrote:
> > > +--On 15 juillet 2015 20:17:14 +0000 Dmitry Marakasov <amdmi3@FreeBSD=
=2Eorg>
> > > wrote:
> > >=20
> > > | +RUN_DEPENDS:=3D ${BUILD_DEPENDS}
> > >=20
> > > Please, do *not* use :=3D for depends, it is wrong.
> > > <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depen=
d.html>
> >=20
> > Can you clarify on what is wrong with :=3D ? I've added IMHO quite cle=
ar and
> > elaborate explanation in the PH on the matter, and I don't see the meri=
t of
> > using MY_DEPENDS at all: it's ugly, it's hard to read, it pollutes name=
space
> > for no sound reason.
> >=20
> > People should learn their tools instead of inventing obscure workaround=
s.
> >=20
> :=3D enforce the expansion to happen right away
>=20
> Let's say you have:
>=20
> RUN_DEPENDS=3D ${BLOODYSCRIPTLANGUAGEPREFIX}bal>0:${PORTSDIR}/somewhere/b=
la
> BULID_DEPENDS:=3D ${RUN_DEPENDS}
>=20
> .include <bsd.port.mk>
>=20
>=20
> BULID_DEPENDS will magically have ${BLOODYSCRIPTLANGUAGEPREFIX} expanded =
to ""
> because it is not yet defined at the moment the expansion is requested.
Well my example is bad here because undefined variable will be expanded lat=
er,
but I think you got the point about inconsistency of the expansion with :=
=3D and
look at the svn history I have fixed a couple of weird issues we hard in the
ports tree due do weirdness of how :=3D do the expansion.
I prefer a sane (yet ugly) constuction that consistently works the same ove=
r the
portstree than I constuction which can bite contributors and get quite comp=
lex
to debug.
Best regards,
Bapt
--m3EZO/+NOdcYnaJL
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlWnd3UACgkQ8kTtMUmk6Ezy8ACgmsxqD/bWMKsaEKoZ1+2UFOj6
iBMAoJQRnymOLyFj+AWlssfVgtvKECSc
=abqu
-----END PGP SIGNATURE-----
--m3EZO/+NOdcYnaJL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150716092053.GX37597>