From owner-svn-ports-all@freebsd.org Thu Jul 16 09:20:58 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59F4B9A2381; Thu, 16 Jul 2015 09:20:58 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com [IPv6:2a00:1450:400c:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8CB81AAC; Thu, 16 Jul 2015 09:20:57 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wgmn9 with SMTP id n9so53310379wgm.0; Thu, 16 Jul 2015 02:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=AgmybEKN7Fuvlp3nEnlUPHnCxNuQSbSPPlE3DbiCiJc=; b=uOWR+eylpUVudQghKYnCdJfjT6Oj3eilRmXdKJ02si+laYI5WcghkDb/St8PEkQgGK Zs6X7nVhBdJ5yTWTH+FLD818rAoU67Ik/nvaivicTPZtXwGYg6HOnU3kN5QIgPlher0J BWyvuhUrNeQpSfMehzYERSFK8vuQ/TeqEYY/NDPVEzvEbOFtt8Ts5lY02vDChuGL6fam xCM8s72RK8V2NU3Bn/GgO4TrTg/sFeEwVczbIzxE8Dvf5VHrsTU9OkB4fdCIWmzdQmUf P3AaBbycbK1CLijpY2aEPMd4p6oNr2UbnVaAJ3HaCjVPf2ASZYoaV+d2Q73fSCPytiGR cNFg== X-Received: by 10.194.8.40 with SMTP id o8mr17204863wja.100.1437038456346; Thu, 16 Jul 2015 02:20:56 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id ev8sm11971478wjb.8.2015.07.16.02.20.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 02:20:55 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 16 Jul 2015 11:20:53 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Mathieu Arnold , Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla Message-ID: <20150716092053.GX37597@ivaldir.etoilebsd.net> References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org> <20150716014306.GA68880@FreeBSD.org> <20150716091021.GW37597@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="m3EZO/+NOdcYnaJL" Content-Disposition: inline In-Reply-To: <20150716091021.GW37597@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 09:20:58 -0000 --m3EZO/+NOdcYnaJL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 16, 2015 at 11:10:22AM +0200, Baptiste Daroussin wrote: > On Thu, Jul 16, 2015 at 01:43:06AM +0000, Alexey Dokuchaev wrote: > > On Wed, Jul 15, 2015 at 10:38:33PM +0200, Mathieu Arnold wrote: > > > +--On 15 juillet 2015 20:17:14 +0000 Dmitry Marakasov > > > wrote: > > >=20 > > > | +RUN_DEPENDS:=3D ${BUILD_DEPENDS} > > >=20 > > > Please, do *not* use :=3D for depends, it is wrong. > > > > >=20 > > Can you clarify on what is wrong with :=3D ? I've added IMHO quite cle= ar and > > elaborate explanation in the PH on the matter, and I don't see the meri= t of > > using MY_DEPENDS at all: it's ugly, it's hard to read, it pollutes name= space > > for no sound reason. > >=20 > > People should learn their tools instead of inventing obscure workaround= s. > >=20 > :=3D enforce the expansion to happen right away >=20 > Let's say you have: >=20 > RUN_DEPENDS=3D ${BLOODYSCRIPTLANGUAGEPREFIX}bal>0:${PORTSDIR}/somewhere/b= la > BULID_DEPENDS:=3D ${RUN_DEPENDS} >=20 > .include >=20 >=20 > BULID_DEPENDS will magically have ${BLOODYSCRIPTLANGUAGEPREFIX} expanded = to "" > because it is not yet defined at the moment the expansion is requested. Well my example is bad here because undefined variable will be expanded lat= er, but I think you got the point about inconsistency of the expansion with := =3D and look at the svn history I have fixed a couple of weird issues we hard in the ports tree due do weirdness of how :=3D do the expansion. I prefer a sane (yet ugly) constuction that consistently works the same ove= r the portstree than I constuction which can bite contributors and get quite comp= lex to debug. Best regards, Bapt --m3EZO/+NOdcYnaJL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWnd3UACgkQ8kTtMUmk6Ezy8ACgmsxqD/bWMKsaEKoZ1+2UFOj6 iBMAoJQRnymOLyFj+AWlssfVgtvKECSc =abqu -----END PGP SIGNATURE----- --m3EZO/+NOdcYnaJL--