From owner-svn-ports-head@freebsd.org Sat Mar 27 06:05:30 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB59C5BA4B6; Sat, 27 Mar 2021 06:05:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F6pGy4SVNz4mns; Sat, 27 Mar 2021 06:05:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (unknown [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 74A732F889; Sat, 27 Mar 2021 06:05:30 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 91FC03B2E0; Sat, 27 Mar 2021 07:05:28 +0100 (CET) Date: Sat, 27 Mar 2021 07:05:28 +0100 From: Baptiste Daroussin To: Cy Schubert Cc: Alexey Dokuchaev , Cy Schubert , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r569288 - head/devel/bitkeeper Message-ID: <20210327060528.d62mjonjx6776lsq@aniel.nours.eu> References: <202103270245.12R2j5Ww059339@repo.freebsd.org> <20210327040518.GA30283@FreeBSD.org> <202103270441.12R4f6Qq059634@slippy.cwsent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4foob2fxu5qn7xlx" Content-Disposition: inline In-Reply-To: <202103270441.12R4f6Qq059634@slippy.cwsent.com> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2021 06:05:30 -0000 --4foob2fxu5qn7xlx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 09:41:06PM -0700, Cy Schubert wrote: > In message <20210327040518.GA30283@FreeBSD.org>, Alexey Dokuchaev writes: > > On Sat, Mar 27, 2021 at 02:45:05AM +0000, Cy Schubert wrote: > > > New Revision: 569288 > > > URL: https://svnweb.freebsd.org/changeset/ports/569288 > > >=20 > > > Log: > > > devel/bitkeeper: pet portlint: compress man pages > > > =20 > > > Compress man pages satisfying portlint. > > > > Well, no, we compress manpages to satisfy common sense and save some > > disk space. :-) > > > > > ... > > > - ${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARG= ET}) > > > + ${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARG= ET});=20 > > \ > > > + ${GZIP_CMD} ${STAGEDIR}${PREFIX}/bitkeeper/man/man1/* > > > + > > >=20 > > > .include > > > > Why not amend MANDIRS to include custom manpage directory so that the > > standard `compress-man' from b.p.m could do its work? Also, you've > > inserted superfluous linefeed there. >=20 > I forgot about that, thanks. I used MANPREFIX instead. >=20 MANDIRS is the right thing to use, MANPREFIX is not support to be overwritt= en and only works by accident here. MANDIRS is the list of directories where we expect to lookup for manpages to compress them. Second if you do install manpages in unusual location, it is expected that = you add this location into manpath for the users to be able to actually access = those manpages. Somehow many ports seems to forget to do it. A good example of what to do h= ere is shown by the perl port which adds a perl5.conf to ETCDIR/man.d (so does = npm) Best regards, Bapt --4foob2fxu5qn7xlx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAmBeyyUACgkQY4mL3PG3 PlpUTQ/9FNYrHbknT36Zm01yw3e4WdT0DfuYbRHh8NnyiJy4y2l3L9ShazOR9ywG ofG3vTxAexl0x+QLctM0FssE7XZltt7dvGt914mxS/3lNceF3krXXJDo35JsM3jt K7W209zj355rU4GCKdFD7dvHCTpTKh/hEwor+xGRDeEfUIPe6rEIwpnERAuNvdSw WcOd5vN5iQHn+aD9AzYuHLnTFY0SqyVRt8xYqt4PAwOld1MJj3TfNBjbLbXM2CRS Rpobg6aizxjWWFHIx2RVe10xHXG4dOQHYfdTLOnNFu7LoUJ6G26gxemptpkCV5uP fNwZyAn1PXQjqztEtf/hXnHXCCCd51pqPD75htLyr3DBnYSxDGUzRgpoNBHbDF1R 1PkDHmXziZqlcwFqDnX9VngCETJUZf9IYAyrRipVtVHRgolHHHJL2C6zUaCyh382 TaRBqLy0Bi0A3yErgz8ja6p9AnTa1kDD5/jKQQoS8cdws1tPVZ/ecAycfkSpqQiX KgGAnkJeQmyhY4sJ+RZsW9AdBPICsD4wD6UOsyLEXlSJNw6bTcO8IJ88Pz+m44KI Xt30APuHDj1Q2gpBo5evcCzr+9mOZz2BTTvlb773dmw/YYNOOCbPKFbj7PLKHJ13 kUlhYgYAfnVvQ5lsLDz7jcJW2WhS4jigaUmOaJlGQ/PjN1WZAVI= =uKJM -----END PGP SIGNATURE----- --4foob2fxu5qn7xlx--