Date: Wed, 2 Jan 2019 20:07:40 +0100 From: Thomas Zander <riggs@freebsd.org> To: Max Brazhnikov <makc@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489088 - head/audio/lastfm-desktop Message-ID: <CAFU734wXMK%2B6-32uE7ebvfy31Q8oJpzu29nyFVzkrSigR3LceA@mail.gmail.com> In-Reply-To: <1653712.CJpZife00y@mercury.ph.man.ac.uk> References: <201901021624.x02GOPKV082363@repo.freebsd.org> <1653712.CJpZife00y@mercury.ph.man.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Max,
On Wed, 2 Jan 2019 at 19:39, Max Brazhnikov <makc@freebsd.org> wrote:
> > Log:
> > Mark BROKEN. Port requires a qt4 build of vlc which was deprecated.
>
> Alternatively, you could have switched the port to phonon-gstreamer backend. In principle,
> ports shouldn't force dependence on Phonon backends at all, any backend can be used.
Un-breaking the port with the phonon-gstreamer backend should still be
possible. As first step, I wanted to workaround a dependency problem.
> > Modified: head/audio/lastfm-desktop/Makefile
> > ==============================================================================
> > --- head/audio/lastfm-desktop/Makefile Wed Jan 2 16:00:00 2019 (r489087)
> > +++ head/audio/lastfm-desktop/Makefile Wed Jan 2 16:24:25 2019 (r489088)
> > @@ -12,6 +12,7 @@ COMMENT= Official Last.fm desktop application suite
> > LICENSE= GPLv3+
> > LICENSE_FILE= ${WRKSRC}/COPYING
> >
> > +BROKEN= Requires vlc-qt4 which was deprecated on 2018-12-31
> > DEPRECATED= Qt4 has been EOL since december 2015
> > EXPIRATION_DATE= 2019-03-15
> >
> > @@ -43,7 +44,8 @@ GSTREAMER_DESC= Multimedia via Phonon-GStreamer
> > GSTREAMER_USES= qt:4
> > GSTREAMER_USE= QT=phonon-gst_run
> > VLC_DESC= Multimedia via Phonon-VLC
> > -VLC_RUN_DEPENDS= phonon-vlc-qt4>=0.6.1:multimedia/phonon-vlc@qt4
> > +#multimedia/phonon-vlc@qt4 flavor was removed due to depreciation of vlc-qt4
> > +#VLC_RUN_DEPENDS= phonon-vlc-qt4>=0.6.1:multimedia/phonon-vlc@qt4
>
> Any reason to keep this?
Only for temporary documentation purposes. As you said, given
interest, the VLC option can be completely removed.
If you have time, feel free to beat me to it. Otherwise I'll look at
it as soon as my machine is no longer busy with the vlc3->vlc
migration test builds.
Riggs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFU734wXMK%2B6-32uE7ebvfy31Q8oJpzu29nyFVzkrSigR3LceA>