From owner-freebsd-gnome@FreeBSD.ORG Sat Jul 21 06:35:12 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by hub.freebsd.org (Postfix) with ESMTP id 0D95A106566B; Sat, 21 Jul 2012 06:35:12 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 16ED614DBC1; Sat, 21 Jul 2012 06:35:11 +0000 (UTC) Message-ID: <500A4D9E.3050701@FreeBSD.org> Date: Fri, 20 Jul 2012 23:35:10 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120621 Thunderbird/13.0.1 MIME-Version: 1.0 To: Jeremy Messenger References: <50098EEF.8040801@shatow.net> <1E76612CE817410FAA2CF925F9CC300A@Rivendell> <5009A876.2010905@freebsd.org> <5009AE6A.1040109@freebsd.org> <5009B199.8030102@freebsd.org> <5009DB2F.5070605@FreeBSD.org> <5009EE56.2060006@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.4.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org, ruby@freebsd.org, johans@freebsd.org, Edwin Groothuis , freebsd-ports@freebsd.org Subject: Re: How to remove erroneous deps from pkgng X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2012 06:35:12 -0000 On 07/20/2012 22:02, Jeremy Messenger wrote: > I prefer to leave it alone and port a feature that I have added in the > bsd.mate.mk (repocopied from bsd.gnome.mk) that support 'USE_GNOME= > foo:build bar:run foobar'. The 'foobar' without the :* means that it's > both build/run time dependency. It's available at: > > http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/ports-experimental/Mk/bsd.mate.mk That sounds like a good fix, although it doesn't look like pkg-config was pulled over. If you decide to do it this way there should probably be a test for things that cannot be one type of dependency or the other so that someone who used pkgconfig:run would get a helpful error message. And of course for things that don't have a : they should get appropriate defaults. By my count there are over 10k ports using just pkgconfig, it's probably a larger number that use other gnome bits. Baptiste already volunteered to do an exp-run for this topic on Monday. If you don't have time to get your changes ready before then IMO we should go ahead with removing the line from bsd.gnome.mk. Making that correct fix now won't negatively affect your ability to make a different/better change later; but doing it now will give us more opportunity to see the results and fix any regressions. If you decide to go forward, please file a PR with your change, and coordinate with Baptiste. Thanks! Doug -- Change is hard.