From owner-freebsd-arch@FreeBSD.ORG Tue Jan 16 20:36:21 2007 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4860A16A49E for ; Tue, 16 Jan 2007 20:36:21 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.245]) by mx1.freebsd.org (Postfix) with ESMTP id 0696113C461 for ; Tue, 16 Jan 2007 20:36:20 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by an-out-0708.google.com with SMTP id c24so1124344ana for ; Tue, 16 Jan 2007 12:36:20 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=e4X8wT0Si9S6zAUEmRhUhH4qfZ1Yrrnfh2/pl8CiZEo1EGlRNGR6Ztl2vrfNN9BzjNA4/KP1e17TRckRRZKtyYRbmUOoHGR0UopQ33RGYD5ii/x8vwMob4UAWnrV5uHzPTacdYyE7q6OcHG4D4K1yZx3qQce59Q0Yo3oDA8Llvg= Received: by 10.49.19.5 with SMTP id w5mr6498912nfi.1168979776259; Tue, 16 Jan 2007 12:36:16 -0800 (PST) Received: by 10.48.238.9 with HTTP; Tue, 16 Jan 2007 12:36:16 -0800 (PST) Message-ID: <3bbf2fe10701161236s48e6cc16p99c8c38c1d7becde@mail.gmail.com> Date: Tue, 16 Jan 2007 21:36:16 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "John Baldwin" In-Reply-To: <200701161438.52481.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <3bbf2fe10607250813w8ff9e34pc505bf290e71758@mail.gmail.com> <3bbf2fe10607281004o6727e976h19ee7e054876f914@mail.gmail.com> <3bbf2fe10701160851r79b04464m2cbdbb7f644b22b6@mail.gmail.com> <200701161438.52481.jhb@freebsd.org> X-Google-Sender-Auth: 1ee207f6857c0685 Cc: Kip Macy , freebsd-current@freebsd.org, Suleiman Souhlal , Pawel Jakub Dawidek , freebsd-arch@freebsd.org Subject: Re: [PATCH] Mantaining turnstile aligned to 128 bytes in i386 CPUs X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2007 20:36:21 -0000 2007/1/16, John Baldwin : > On Tuesday 16 January 2007 11:51, Attilio Rao wrote: > > 2006/7/28, Attilio Rao : > > > > > > After some thinking, I think it's better using init/fini methods > > > (since they hide the sizeof(struct turnstile) with size parameter). > > > > > > Feedbacks and comments are welcome: > > > http://users.gufi.org/~rookie/works/patches/uma_sync_init.diff > > > > [CC'ed all the interested people] > > > > Even if a long time is passed I did some benchmarks based on ebizzy tool. > > This program claims to reproduce a real httpd server behaviour and is > > used into the Linux world for benchmarks, AFAIK. > > I think that results of the comparison on this patch is very > > interesting, and I think it worths a commit :) > > I think that results can be even better on a Xeon machine (I had no > > chance to reproduce this on some of these). > > (Results taken in consideration have been measured after some starts, > > in order to minimize caching differences). > > > > The patch: > > http://users.gufi.org/~rookie/works/patches/ts-sq/ts-sq.diff > > Looks good. Some minor nits are that in subr_turnstile.c in the comment I > would say "a turnstile is allocated" rather than "a turnstile is got from a > specific UMA zone" as it reads a little bit clearer. Also, I would > say "Allocate a" rather than "Get a" for the two _alloc() functions. Also, > why not just use UMA_ALIGN_CACHE and make UMA_ALIGN_CACHE (128 - 1) on i386 > and amd64 rather than adding a new UMA_ALIGN_SYNC? I was thinking that in this way anyone who wants to replace the syncronizing primitive boundary to an appropriate value can do it. I just used UMA_ALIGN_CACHE as default value beacause I don't know the better boundary (for syncronizing primitives) for other arches. Attilio -- Peace can only be achieved by understanding - A. Einstein