From owner-svn-ports-head@FreeBSD.ORG Thu Aug 21 22:10:33 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3FF07E4B; Thu, 21 Aug 2014 22:10:33 +0000 (UTC) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.allbsd.org", Issuer "RapidSSL CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B63DF3CC8; Thu, 21 Aug 2014 22:10:32 +0000 (UTC) Received: from alph.d.allbsd.org ([IPv6:2001:2f0:104:e010:862b:2bff:febc:8956]) (authenticated bits=56) by mail.allbsd.org (8.14.9/8.14.8) with ESMTP id s7LMA7Qr026013 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 22 Aug 2014 07:10:18 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.8/8.14.8) with ESMTP id s7LMA4rq060151; Fri, 22 Aug 2014 07:10:06 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 22 Aug 2014 07:09:39 +0900 (JST) Message-Id: <20140822.070939.1253386656808735449.hrs@allbsd.org> To: marino@freebsd.org, freebsd.contact@marino.st Subject: Re: svn commit: r365590 - in head/cad/spice: . files From: Hiroki Sato In-Reply-To: <53F663B2.3000800@marino.st> References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.6 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Aug_22_07_09_39_2014_662)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mail.allbsd.org [IPv6:2001:2f0:104:e001::32]); Fri, 22 Aug 2014 07:10:26 +0900 (JST) X-Spam-Status: No, score=-97.9 required=13.0 tests=CONTENT_TYPE_PRESENT, RDNS_NONE,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2014 22:10:33 -0000 ----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit John Marino wrote in <53F663B2.3000800@marino.st>: fr> On 8/21/2014 21:41, Hiroki Sato wrote: fr> > Author: hrs fr> > Date: Thu Aug 21 19:41:06 2014 fr> > New Revision: 365590 fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590 fr> > QAT: https://qat.redports.org/buildarchive/r365590/ ... fr> I'm sorry, but using freebsd-specific in a ports vendor fr> makefile is NOT an improvement and frankly puts the build at risk on fr> DragonFly. fr> fr> I wish there was a rule that ports should not use system make fragments. fr> This is not a good practice. This port had a perfectly working and fr> generic makefile before. fr> fr> There's a good chance this just broke spice on DragonFly as the system fr> make file these are different. I can understand that vendor's Makefile should be platform-neutral, but I do not think there is advantage to maintain ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff because it is used only by the port. Should we care about build on DragonFly? -- Hiroki ----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlP2biMACgkQTyzT2CeTzy2h5gCgp+gfgDTkBNZPHH293lBZkonc L8oAoNvSHaLK11SA7Bxqg5QluMwoi2BD =2RHe -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Aug_22_07_09_39_2014_662)----