From owner-svn-ports-head@freebsd.org Sun Mar 6 02:25:11 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10AF7A92118; Sun, 6 Mar 2016 02:25:11 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D5D817D6; Sun, 6 Mar 2016 02:25:10 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x22e.google.com with SMTP id 63so58185879pfe.3; Sat, 05 Mar 2016 18:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=i0JxoF2J+qL0ui0qyBysWstILSXbByPOgMGeUpqYkcY=; b=kAa0VW+n9SMB9geO/zvJino9oRYK60wLuTusx/hPiSNO7DOtMBTIYFcDF2HKLrBDIB mWgYEk+5nCuiEYnyGqGgLhEjdk9hF88prNYG3Hy333h1FMOJ60tfGEO+kDJ2k48Ak8M5 eqO4lZFzBXLCupPZ4LX6BIWNlTD+YH4Jar16E0Y9TrPxQ60+WLZsiI4ZKqRW+NsTxjYc 7drjaPS7CVHLC+vhxSZ6CDheD8IVBoMtUoD50ApAFy8tMi/rqvEG2Wzfqeeb8Lc6T+pf 3MRskOSevvuuATKVSPKYh0aNlRDaAY01a7vmvhHfzPYUZTge7EvJbPnwPQneAl3HEnjc ZIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=i0JxoF2J+qL0ui0qyBysWstILSXbByPOgMGeUpqYkcY=; b=gyrEFQ77JCUvtkc61EUaSo/aLEuOCG9rQWZLI0uQxoWnkfLtNcG1iSkz++dWO4t9TK w7YXd5L34AHZp8wJiOjfDqZiEKMAdJg5JNTxGzTimVo5Obvq9W0QUnQI+ScBHd71uOu1 ajdsCdt+UhK3IgKOodX+qRIovhOMkDHyHaEA8djjt7sRPx+xtlzrX4Cg8shsE+g/C+Sq xKgK2maYmiJhaKfxgFv4kZDX3Kr80hYWY3cGHD6FjG5nqVKhAoIea+gPJuqGgZHYoJW3 D732EK6hjVHiBwfWdXNFzFmV27bFNL+Bjx7ZY53YCMZWrLaCfzuK8KEfpGg4FoHs6liu RctA== X-Gm-Message-State: AD7BkJL22uMX80/wgcpTakDp0Jo6PxcwEWb5YgcQqp5A54aFNvFNDvh+tiYcMKKYzwtNgA== X-Received: by 10.98.93.2 with SMTP id r2mr23848023pfb.64.1457231110477; Sat, 05 Mar 2016 18:25:10 -0800 (PST) Received: from ?IPv6:2001:44b8:31ae:7b01::1? (2001-44b8-31ae-7b01-0000-0000-0000-0001.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01::1]) by smtp.gmail.com with ESMTPSA id p79sm10610961pfi.61.2016.03.05.18.25.08 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Mar 2016 18:25:10 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r410226 - in head/security/py-pynacl: . files References: <201603060214.u262E6qw060638@repo.freebsd.org> To: Wen Heping , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kubilay Kocak Message-ID: Date: Sun, 6 Mar 2016 13:24:58 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <201603060214.u262E6qw060638@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2016 02:25:11 -0000 On 6/03/2016 1:14 PM, Wen Heping wrote: > > -BUILD_DEPENDS= ${LOCALBASE}/lib/libnacl.a:${PORTSDIR}/security/nacl \ > - ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi > -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi > +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}cffi>0:${PORTSDIR}/devel/py-cffi \ > + ${PYTHON_PKGNAMEPREFIX}six>0:${PORTSDIR}/devel/py-six > +BUILD_DEPENDS= ${RUN_DEPENDS} This is likely incorrect, both in terms of it's assignment and that six is not a BUILD_DEPENDS. It's better to explicitly list BUILD_DEPENDS, even if it means duplicating some of the entries of RUN_DEPENDS > +LIB_DEPENDS= libsodium.so:${PORTSDIR}/security/libsodium > > USES= python > USE_PYTHON= autoplist distutils > -NO_ARCH= yes > +MAKE_ENV+= SODIUM_INSTALL=system > +CFLAGS+= -I ${LOCALBASE}/include > Do we know what why CFLAGS is needed and why wasn't it needed before? Also use USES=localbase instead ./koobs