Date: Mon, 16 Sep 2013 12:28:46 -0400 From: John Baldwin <jhb@freebsd.org> To: "Jean-Sebastien Pedron" <dumbbell@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255573 - head/sys/dev/drm2/radeon Message-ID: <201309161228.46123.jhb@freebsd.org> In-Reply-To: <201309141724.r8EHOgj8060898@svn.freebsd.org> References: <201309141724.r8EHOgj8060898@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, September 14, 2013 1:24:42 pm Jean-Sebastien Pedron wrote: > Author: dumbbell > Date: Sat Sep 14 17:24:41 2013 > New Revision: 255573 > URL: http://svnweb.freebsd.org/changeset/base/255573 > > Log: > drm/radeon: Fix usage of pci_save_state() and pci_restore_state() > > Calling those functions with the drmn device as argument causes a panic, > because it's not a direct child of pci$N. They must be called with the > vgapci device instead. > > This fix is not enough to make suspend/resume work reliably. > > Approved by: re (blanket) Note that the PCI bus layer already does pci_save_state() during suspend and pci_restore_state() during resume, so it is redundant for a driver to do so. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201309161228.46123.jhb>