Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Aug 1995 10:16:22 -0700 (PDT)
From:      "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
To:        asami@cs.berkeley.edu (Satoshi Asami)
Cc:        CVS-commiters@freefall.cdrom.com, cvs-ports@freefall.cdrom.com
Subject:   Re: cvs commit: ports/devel/noweb/work/contrib/norman/numarkup Makefile numarkup.aux numarkup.bbl numarkup.nw
Message-ID:  <199508081716.KAA04204@gndrsh.aac.dev.com>
In-Reply-To: <199508081214.FAA07991@silvia.HIP.Berkeley.EDU> from "Satoshi Asami" at Aug 8, 95 05:14:00 am

next in thread | previous in thread | raw e-mail | index | archive | help
> 
>  * From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
> 
>  * AHh.. I was wondering why I did not see a commit for this.  Since this was
>  * caught so soon and cvs removed right away no one had a chance to cvs co it,
>  * and the cron jobs have all run at least once since the import I took the
>  * gamble and just did:
>  * freefall:rgrimes {113} pwd
>  * /b/ncvs/ports/devel/noweb
>  * freefall:rgrimes {114} rm -rf work
> 
> Thanks....

Welcome...

>  * From: Peter Wemm <peter@haywire.DIALix.COM>
> 
>  * Hmm. If Rod has any sense, he's be asleep.. :-)
> 
> You don't know Rod.... :>

Right... but he is getting to know me better by the day!!  [Quit a stack
of private email between us.]

>  * I removed it.. (fingers crossed) There didn't seem to be any point in 
>  * creating an Attic for it as it's bogus..
> 
> Um, I thought the repository operations are restricted to the
> repository manager (currently Rod) only.  Did this change?

Yes, this has changed midly for right now.  Though I did not official
tell Peter he could cut loose in the repository for major operations he
does have my full blessing for emergency repair work, and he used good
judgement here.  A zero length file will only hurt things, rm'ing it
was the only reasonable thing to do with it.

> By the way, how did both of you manage to remove it successfully
> without (at least) one of you getting an error message from rm? ;)

He removed the file, I removed the whole tree with rm -r, he must have
finished his command before my rm -r traversed that part of the tree.

>  * Umm. did you panic and hit ^C during the import by any chance?
> 
> No...I know better than that. ;)  I bit my lips and was looking at the 
> import progress report, and it just blew up by itself.

Okay, looks like we have a bug to go find.  I need to make some busy
work for Peter so I can catch up with him on a few things anyway :-).

Peter, see if you can reproduce the ``cvs import that barfs due to permission
errors and creates a bogus ,v file in the repository'' bug and fix it.

>  * BTW, how long before that 24-hour grace period is up?
> 
> The import was right before my "Argh!" mail.  By the way, I was just
> copying Rod in the 24-hour thing....

To reiterate what I said in other email so Peter knows when I start this
clock it is _72_ hours from the time of the commit that places the file
into the Attic.  For a damaged file like the above case the time limit
becomes 0 and the rule broken that says it must be in the Attic before the
remove since you can't check it out to put it in the Attic :-)

I broke the rule (as stated in my reply to Satoshi) and rm -r the work
tree that was accidentally imported since it was placed into the Attic
within minutes of the import operation.

To others, if you blow an import of any kind, please, as soons as possible
after the error cvs remove all the files, this cuts the grace period as it
minimized the chance that some place actually checked out the bad copy of
the files and does not require me to do that step later when cleaning up.
This is especially true if you import to the wrong location, as then you
can go reimport to the right location without waiting for me, and I can
come along and clean up the bad import the next day without any fuss.  [I
often save 2 or 3 of these up and do them in bulk when I am wide awake,
and have a fresh repository backup incase I blow an rm -r some place :-)]


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                 Reliable computers for FreeBSD



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508081716.KAA04204>