From owner-freebsd-current@FreeBSD.ORG Tue Jan 11 19:13:55 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC9416A4CE; Tue, 11 Jan 2005 19:13:55 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A2CB43D58; Tue, 11 Jan 2005 19:13:55 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j0BJDrGV009633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 11 Jan 2005 11:13:54 -0800 Message-ID: <41E42570.8040503@root.org> Date: Tue, 11 Jan 2005 11:13:52 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <20587818.1102626838092.JavaMail.tomcat@pne-ps4-sn1> <41DEED05.4040000@root.org> <41DF0839.6040700@telia.com> <200501071728.16828.jhb@FreeBSD.org> <41DF2BB3.60800@root.org> <41DF347E.6010305@telia.com> <41DF5159.1090106@root.org> <41DF5DEA.3030904@telia.com> <41DF9481.5030305@root.org> <41DFA2FF.0@telia.com> <41E02AD7.5000005@root.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-current@FreeBSD.org Subject: Re: page fault panic in device_get_softc/acpi_pcib_route_interrupt X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2005 19:13:55 -0000 John Baldwin wrote: > > On Jan 8, 2005, at 1:47 PM, Nate Lawson wrote: > >> Pawel Worach wrote: >> >>> Nate Lawson wrote: >>> --- sys/dev/acpica/acpi_pcib.c 27 Dec 2004 05:36:47 -0000 1.53 >>> +++ sys/dev/acpica/acpi_pcib.c 8 Jan 2005 09:05:57 -0000 >>> @@ -249,11 +249,18 @@ >>> /* >>> * We have to find the source device (PCI interrupt link device). >>> */ >>> - if (ACPI_FAILURE(AcpiGetHandle(ACPI_ROOT_OBJECT, prt->Source, >>> &lnkdev))) { >>> + if (ACPI_FAILURE(AcpiGetHandle(acpi_get_handle(pcib), prt->Source, >>> + &lnkdev))) { >>> device_printf(pcib, "couldn't find PCI interrupt link device %s\n", >>> prt->Source); >>> goto out; >>> } >> >> >> This change should not be committed. I think it's correct to use \ to >> start the search since your _PRT contains relative references but the >> links are under \. > > > So, should I change the code to force-attach the devices to also use > ACPI_ROOT_OBJECT for its lookup as well in prt_attach_devices()? > Sure, I think that's a good idea. -- Nate