Date: Tue, 8 Aug 2006 14:00:50 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Prafulla Deuskar <pdeuskar@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Message-ID: <20060808100050.GM54416@comp.chem.msu.su> In-Reply-To: <20060807114556.GC96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <20060804151422.GE96644@FreeBSD.org> <20060804162149.GB22299@hub.freebsd.org> <20060807114556.GC96644@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: > > P> Is there a report on what coverty found with if_em_hw.c? > > Coverity complains that the return value of em_read_phy_reg() is > somtimes checked and sometimes is not. Can you please tell, whether > this is important report or can it be ignored? FWIW, a return value can be cast to (void) to tell explicitly that it doesn't matter. While ignoring a return value from a well-known function, such as close(), looks mostly OK to code readers (the author knows what he's doing, they think,) it may not be the case for a local function of limited application. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060808100050.GM54416>