From owner-freebsd-bugs@freebsd.org Mon Sep 12 05:01:38 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED4CBBD61B6 for ; Mon, 12 Sep 2016 05:01:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA02E14EE for ; Mon, 12 Sep 2016 05:01:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u8C51cOS009312 for ; Mon, 12 Sep 2016 05:01:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 212595] ipfw can't enable or disable sets 5 to 30 Date: Mon, 12 Sep 2016 05:01:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RC1 X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avernar@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 05:01:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212595 Bug ID: 212595 Summary: ipfw can't enable or disable sets 5 to 30 Product: Base System Version: 11.0-RC1 Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: avernar@gmail.com Using ipfw you can't enable or disable sets if any set 5 or higher are specified: # ipfw set disable 1 # ipfw set disable 2 # ipfw set disable 3 # ipfw set disable 4 # ipfw set disable 5 ipfw: set enable/disable: setsockopt(IP_FW_SET_ENABLE): Invalid argument # ipfw set disable 1 2 3 # ipfw set disable 1 2 4 # ipfw set disable 1 2 5 ipfw: set enable/disable: setsockopt(IP_FW_SET_ENABLE): Invalid argument The problem is in ip_fw_sockopt.c in the manage_sets function. For IP_FW_SET_ENABLE the rh->range.set and rh->range.new_set variables are bitm= asks and not a single set number. This is because multiple sets can be disabled= and enabled with a single call. The new check against IPFS_MAX_SETS in that function is triggered since if = set 5 or higher is specified the value of those variables is 32 or higher. For the IP_FW_SET_SWAP and IP_FW_SET_MOVE those two variables are indeed set numbers so the check is valid. The check should be moved inside the switch just for those two cases. --=20 You are receiving this mail because: You are the assignee for the bug.=