Date: Thu, 27 Nov 2014 17:00:38 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, jbeich@vfemail.net, ports-committers@freebsd.org Subject: Re: svn commit: r373458 - in head/www: linux-c6-flashplugin11 linux-f10-flashplugin11 Message-ID: <20141127170038.2d48e014@kalimero.tijl.coosemans.org> In-Reply-To: <5476E1A5.1010307@marino.st> References: <201411261948.sAQJmO9U029389@svn.freebsd.org> <20141126211459.241dfadb@kalimero.tijl.coosemans.org> <547635FD.5080407@marino.st> <20141127092101.3f977182@kalimero.tijl.coosemans.org> <5476E1A5.1010307@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Nov 2014 09:32:37 +0100 John Marino <freebsd.contact@marino.st> wrote: > On 11/27/2014 09:21, Tijl Coosemans wrote: >> On Wed, 26 Nov 2014 21:20:13 +0100 John Marino <freebsd.contact@marino.st> wrote: >>> On 11/26/2014 21:14, Tijl Coosemans wrote: >>>> On Wed, 26 Nov 2014 19:48:24 +0000 (UTC) John Marino <marino@FreeBSD.org> wrote: >>>>> +%%NO_ALSA%%%%LINUXBASE%%/usr/lib/libflashsupport.so >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr/lib >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%% >>>>> +%%NO_ALSA%%@dir %%COMPATDIR%% >>>> >>>> Traditionally /compat is a symlink to /usr/compat, so I'm not sure it's >>>> safe to delete it like this. But even if it is this port depends on >>>> emulators/linux_base so none of these @dir are necessary. >>> >>> The port was creating empty directories in stagedir when ALSA option is >>> off. So at least in one case, they are necessary (or deleting from >>> stagedir is necessary). Nothing is getting deleted. >> >> The directory %%LINUXBASE%%/usr/lib isn't empty. It contains >> libflashsupport.so. And that directory belongs to emulators/linux_base >> so this port does not have to list it with @dir. > > So at worst it's a no-op, right? pkg won't create a directory if it > already exists - and won't delete if it's still contains files. Yes, you're right, it's always a no-op. > make check-plist was coming back with *errors*. I don't want to accept > errors as normal. No port should fail -t checks in poudriere. Do you > know a better solution that doesn't result in make check-plist failure? > > Perhaps removing the directories from stagedir instead? No the directory isn't empty so you cannot delete it. I think the proper fix is to add /usr/compat to /etc/mtree/BSD.usr.dist and let the base system create /compat as a symlink to it. Then @dir %%COMPATDIR%% can be removed. The others can stay.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141127170038.2d48e014>