From owner-freebsd-fs@FreeBSD.ORG Mon Jul 26 12:30:10 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D555A1065673 for ; Mon, 26 Jul 2010 12:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C903C8FC0C for ; Mon, 26 Jul 2010 12:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6QCUAi0065417 for ; Mon, 26 Jul 2010 12:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6QCUAmp065410; Mon, 26 Jul 2010 12:30:10 GMT (envelope-from gnats) Date: Mon, 26 Jul 2010 12:30:10 GMT Message-Id: <201007261230.o6QCUAmp065410@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Andriy Gapon Cc: Subject: Re: bin/148296: [zfs] [loader] [patch] Very slow probe in /usr/src/sys/boot/zfs/zfs.c X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andriy Gapon List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2010 12:30:10 -0000 The following reply was made to PR bin/148296; it has been noted by GNATS. From: Andriy Gapon To: Jimmy Olgeni Cc: "Andrey V. Elsukov" , bug-followup@FreeBSD.org, Norikatsu Shigemura Subject: Re: bin/148296: [zfs] [loader] [patch] Very slow probe in /usr/src/sys/boot/zfs/zfs.c Date: Mon, 26 Jul 2010 15:23:00 +0300 on 26/07/2010 14:56 Jimmy Olgeni said the following: > > Hello, > > On Wed, 14 Jul 2010, Andrey V. Elsukov wrote: > >> just one note - user can create partition that doesn't start from 1. >> For example: >> # mdconfig -s 100m >> # gpart create -s gpt md0 >> # gpart add -i 5 -t freebsd-zfs md0 > > This is slower, but safer: it doesn't fall back to slices, and only > skips checks when a vdev is found at the unit level. I still think that we need a method for querying partition scheme and available partitions for a disk. Perhaps for "biosdisk" only at this point. Just look into sys/boot/i386/libi386/biosdisk.c, bd_open/bd_open_gpt/bd_open_mbr to see what a waste each blind probe is. -- Andriy Gapon