From owner-cvs-src@FreeBSD.ORG Tue Apr 15 09:08:23 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DC7037B401 for ; Tue, 15 Apr 2003 09:08:23 -0700 (PDT) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36E0843F85 for ; Tue, 15 Apr 2003 09:08:21 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 32426 invoked from network); 15 Apr 2003 16:08:25 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 15 Apr 2003 16:08:25 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3FG8FOv069600; Tue, 15 Apr 2003 12:08:16 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030416004432.N1564@gamplex.bde.org> Date: Tue, 15 Apr 2003 12:08:17 -0400 (EDT) From: John Baldwin To: Bruce Evans cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Robert Watson cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2003 16:08:23 -0000 On 15-Apr-2003 Bruce Evans wrote: > On Mon, 14 Apr 2003, Robert Watson wrote: > >> rwatson 2003/04/14 14:45:12 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/conf options >> Log: >> Add MAC_ALWAYS_LABEL_MBUF to options; this permits the administrator >> to force the allocation of MAC labels for all mbufs regardless of >> whether a configured policy requires labeling when the mbuf is >> allocated. This can be useful it you anticipate loading a fully >> labeled policy after boot and don't want mbufs to exist without >> label storage, for performance measurement purposes, etc. It also >> slightly lowers the overhead of m_tag labeling due to removing the >> decision logic. > > This seems to be missing in NOTES. > >> While here, improve commenting of other MAC options. > > This unimproves the commenting, since individual options should only be > commented on in 1 place (not here). This file shouldn't contain any > comments except meta-comments about what to put in it and technical > details. There are good examples of these at the start of the file. > More examples: > > # Do not add comments on individual options in this file! > # Put comments on options in NOTES, not here! > # These rules should go without saying - see commit history > >> Obtained from: TrustedBSD Project >> Sponsored by: DARPA, Network Associates Laboratories >> >> Revision Changes Path >> 1.388 +7 -1 src/sys/conf/options > > Should be more like +1 -4 to remove the comments, or larger to move the > options. Options that use a prefix so that it is obvious what subsystem > they are for are grouped naturally if they are sorted normally. Here is > an old patch that moves the MAC options and fixes a few of the other > style bugs in this file. Could you please commit this modulo the GEOM => NO_GEOM change? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/